commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <GGreg...@seagullsoftware.com>
Subject RE: svn commit: r1006099 - /commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java
Date Sat, 09 Oct 2010 07:03:25 GMT
Random thought:

Instead of trying to cause an OutOfMemoryException, how about throwing this exception ourselves
from a (test) subclass of the IO class in that we are trying to break?

Gary

-----Original Message-----
From: niallp@apache.org [mailto:niallp@apache.org] 
Sent: Friday, October 08, 2010 18:55
To: commits@commons.apache.org
Subject: svn commit: r1006099 - /commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java

Author: niallp
Date: Sat Oct  9 01:55:02 2010
New Revision: 1006099

URL: http://svn.apache.org/viewvc?rev=1006099&view=rev
Log:
IO-161 Try garbage collecting before trying to fill memory

Modified:
    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java

Modified: commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java?rev=1006099&r1=1006098&r2=1006099&view=diff
==============================================================================
--- commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java
(original)
+++ commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java
Sat Oct  9 01:55:02 2010
@@ -302,6 +302,8 @@ public class FileCleaningTrackerTestCase
     }
 
     private void waitUntilTrackCount() throws Exception {
+        System.gc(); 
+        Thread.sleep(500);
         int count = 0;
         while(theInstance.getTrackCount() != 0 && count++ < 5) {
             List<String> list = new ArrayList<String>();
@@ -312,7 +314,6 @@ public class FileCleaningTrackerTestCase
                 }
             } catch (Throwable ignored) {
             }
-            list.clear();
             list = null;
             System.gc(); 
             Thread.sleep(1000);


Mime
View raw message