commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <GGreg...@seagullsoftware.com>
Subject RE: [VOTE] Release Commons IO 2.0 based on RC5
Date Fri, 15 Oct 2010 17:56:00 GMT
Hi All:

I downloaded and tested building on Oracle Java 1.6.0_21 64 bit on Windows Vista 64 bit with
Ant 1.8.1 and Maven 2.2.1. All is well with the build and unit tests.

Findbugs is not part of the build, so I added it and I have some questions:

(1) doCopyDirectory and another methods that call setLastModified.

In:

private static void doCopyDirectory(File srcDir, File destDir, FileFilter filter,
            boolean preserveFileDate, List<String> exclusionList) throws IOException
{
...
        // Do this last, as the above has probably affected directory metadata
        if (preserveFileDate) {
            destDir.setLastModified(srcDir.lastModified());
        }
    }


Yields:

FileUtils.java:1101 org.apache.commons.io.FileUtils.doCopyDirectory(File, File, FileFilter,
boolean, List) ignores exceptional return value of java.io.File.setLastModified(long)

Since the caller specifically asks for /preserveFileDate/ I would assume that the cares whether
it worked or not. Otherwise this should be "quietlyTryToPreserveFileDate"

It seems like the method should either return a Boolean or throw an exception.

Same issue with:

FileUtils.java:827 org.apache.commons.io.FileUtils.doCopyFile(File, File, boolean) ignores
exceptional return value of java.io.File.setLastModified(long)

Same kind of issue with:

FileUtils.java:2060 org.apache.commons.io.FileUtils.moveDirectoryToDirectory(File, File, boolean)
ignores exceptional return value of java.io.File.mkdirs()
FileUtils.java:2135 org.apache.commons.io.FileUtils.moveFileToDirectory(File, File, boolean)
ignores exceptional return value of java.io.File.mkdirs()

There are a couple more that I am looking at...

-
Gary Gregory

> -----Original Message-----
> From: Simone Tripodi [mailto:simone.tripodi@gmail.com]
> Sent: Friday, October 15, 2010 01:17
> To: Commons Developers List
> Subject: Re: [VOTE] Release Commons IO 2.0 based on RC5
> 
> Hi Niall,
> should the clirr report link located on
> http://people.apache.org/~niallp/io-2.0-rc5/site/clirr-report.html
> instead of http://people.apache.org/~niallp/io-2.0-rc4/site/clirr-report.html?
> 
> I can't speak about the implementation stuff because my knowledge on
> IO is not good enough, but release looks good, mvn stuff are ok,
> generated site (known broken links a part) seems ok.
> Tested with both java5 and java6:
> 
> ------------------------------------------------------------------------------
> -------------------------------------------
> 
> Darwin Simones-Computer-2.local 10.4.0 Darwin Kernel Version 10.4.0:
> Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> 
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02-279-10M3065)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01-279, mixed mode)
> 
> Apache Maven 3.0 (r1004208; 2010-10-04 13:50:56+0200)
> Java version: 1.6.0_20
> Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x" version: "10.6.4" arch: "x86_64" Family: "mac"
> 
> Tests run: 744, Failures: 0, Errors: 0, Skipped: 0
> 
> ------------------------------------------------------------------------------
> -------------------------------------------
> 
> Darwin Simones-Computer-2.local 10.4.0 Darwin Kernel Version 10.4.0:
> Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> 
> java version "1.5.0_24"
> Java(TM) 2 Runtime Environment, Standard Edition (build
> 1.5.0_24-b02-357-10M3065)
> Java HotSpot(TM) Client VM (build 1.5.0_24-149, mixed mode, sharing)
> 
> Apache Maven 3.0 (r1004208; 2010-10-04 13:50:56+0200)
> Java version: 1.5.0_24
> Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.5.0/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x" version: "10.6.4" arch: "i386" Family: "unix"
> 
> Tests run: 744, Failures: 0, Errors: 0, Skipped: 0
> 
> I don't know if my vote is binding or not, BTW I express my +1
> Have a nice day,
> Simo
> 
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
> 
> 
> 
> On Fri, Oct 15, 2010 at 4:14 AM, Niall Pemberton
> <niall.pemberton@gmail.com> wrote:
> > I have prepared Commons IO 2.0 RC5. The main changes since RC4 was to
> > rename the FilesystemObserver/Monitor to
> > FileAlterationObserver/Monitor and improvements to the test coverage.
> >
> > The RC3 changes were improvements to some tests which were causing
> > intermittent failures in Gump & Continuum and JavaDoc improvements.
> > For details about Continuum builds/failures, see:
> >  http://people.apache.org/~niallp/io-2.0/IOFailures.html
> >
> > The distro is here:
> >  http://people.apache.org/~niallp/io-2.0-rc5/
> >
> > Release Notes:
> >  http://people.apache.org/~niallp/io-2.0-rc5/RELEASE-NOTES.txt
> >
> > Site:
> >  http://people.apache.org/~niallp/io-2.0-rc5/site/
> >
> > Maven Stuff:
> >  http://people.apache.org/~niallp/io-2.0-rc5/maven/
> >
> > Some Notes:
> >
> > * There is one error on the clirr report - which is a false positive
> > (a generic method that is erased)
> >  http://people.apache.org/~niallp/io-2.0-rc4/site/clirr-report.html
> > * Links to the JavaDoc versions on the site don't work (they will when
> > its deployed to the right location)
> >
> > Thanks
> >
> > Niall
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

Mime
View raw message