Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 209.85.161.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=qYx5kgqHDEMw6553ZuiAIQy+vgjflq97SISDP+KOchw+H7ZyBOSPvgIV8IgjIKfIn5
         /hWmDoT53Du+fbn/QFtvDh5MUcXw3gTSSnzlaMSUq5tDFN6G5Tk7FdXMZ8RGll3A0n2O
         zfhZPNK9VFfvYjdtjpEv4sCRL/QdyCnDMVrbk=
MIME-Version: 1.0
In-Reply-To: <AANLkTingtgY0H71MZnA8jwTEFajkQycahJo5UDHMJ6_c@mail.gmail.com>
References: <AANLkTi=WzW_6LAEic=dvOiRq3oUDTEXRK3TsBPBQtpKV@mail.gmail.com>
	<AANLkTingtgY0H71MZnA8jwTEFajkQycahJo5UDHMJ6_c@mail.gmail.com>
Date: Thu, 30 Sep 2010 03:21:28 +0100
Message-ID: <AANLkTik51JCFNKd--JUOHhsZwvkpVzk_qw-uABtaq9eo@mail.gmail.com>
Subject: Re: [IO] Tailer API
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 30 September 2010 02:58, Niall Pemberton <niall.pemberton@gmail.com> wro=
te:
> On Thu, Sep 30, 2010 at 2:46 AM, sebb <sebbaz@gmail.com> wrote:
>> Just wondering if the Tailer API could be simplified by performing the
>> thread start within the class?
>> Is it ever going to be useful to have direct access to tailer thread?
>> I suspect not, as the Listener should provide sufficient access.
>>
>> It's not safe to start a thread in the constructor (unless the ctor is
>> final), but one could use static factory methods instead.
>>
>> So instead of:
>>
>> =A0TailerListener listener =3D ...
>> =A0Tailer tailer =3D new Tailer(file, listener, delay);
>> =A0Thread thread =3D new Thread(tailer);
>> =A0thread.start();
>> =A0...
>> =A0tailer.stop()
>>
>> one would do something like:
>>
>> =A0TailerListener listener =3D ...
>> =A0Tailer tailer =3D Tailer.createTailer(file, listener, delay);
>> =A0...
>> =A0tailer.stop()
>>
>> This simplifies the API, and allows the class to force the thread to
>> be a daemon thread. It also stops the caller from messing with the
>> thread.
>>
>> WDYT?
>
> There are five different Thread constructors that take a Runnable and
> a bunch of other methods that someone might want to use. I don't have
> a problem providing a convenience static method - but it only saves
> two lines of code - as long as they can construct one manually with or
> without a Thread if they want to.

But what is the use case for having access to the created thread?
Seems to me it would be a lot safer if the thread were private to the class=
.

It would still be possible to use the code without a thread by
exposing the method that loops over the file, and using the
constructor instead.
For example with the current code one could do something like:

TailerListener listener =3D ...
Tailer tailer =3D new Tailer(file, listener, delay);
tailer.run()

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org