Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 30892 invoked from network); 17 Sep 2010 17:18:29 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Sep 2010 17:18:29 -0000 Received: (qmail 94349 invoked by uid 500); 17 Sep 2010 17:18:28 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 94209 invoked by uid 500); 17 Sep 2010 17:18:27 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 94201 invoked by uid 99); 17 Sep 2010 17:18:27 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Sep 2010 17:18:27 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates 209.85.216.43 as permitted sender) Received: from [209.85.216.43] (HELO mail-qw0-f43.google.com) (209.85.216.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Sep 2010 17:18:04 +0000 Received: by qwj8 with SMTP id 8so2569296qwj.30 for ; Fri, 17 Sep 2010 10:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Au+RLt2toFJjPr+Lj7guOTjjStQH6TYqWY3cfYwoZPc=; b=nYj5iw/J/r9EUi9H9MRS07yplg16AsQ0W2Op6ySJHFHISYc/7w6TFTzUi2GjNlqEOu 9m6KwOeEXVCV74j2YxB9QGU3t4/HWG1i+ofPlFAQ2loCQ+fZQ2TC/eek+WiP1/+6UeBL RZuTUg7dVL3OIMsVUUE0TTcDlkg+9kG++/19M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=bTDwr+7FRgt0koI3ZxnJwH15sJzjzfr+j1HNDs9KLzdCek6/v5kCpSMYOt7zT2wHr7 4TGTN+LJkZlOMg0QrUpHOVRX4D8VFhgAiLXygLjl547xcnJWEa3HZRSOKBjrnn0GNJvM 3Qn5sYH25sl/xo8QkpgqBxohIiyeRH06omGOQ= MIME-Version: 1.0 Received: by 10.224.3.3 with SMTP id 3mr3539255qal.181.1284743863623; Fri, 17 Sep 2010 10:17:43 -0700 (PDT) Received: by 10.229.215.200 with HTTP; Fri, 17 Sep 2010 10:17:43 -0700 (PDT) In-Reply-To: References: Date: Fri, 17 Sep 2010 10:17:43 -0700 Message-ID: Subject: Re: [SANSELAN] Fixing test case Eclipse warnings From: Henri Yandell To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Sounds like a good idea to me. On Fri, Sep 17, 2010 at 7:40 AM, Charles Matthew Chen wrote: > =A0 Thanks for the perspective Hen. =A0It sounds like good advice. > > =A0 I do think there would be a benefit to hitting control-f (ie. > autoformat) once for the whole project; its pretty messy now. =A0I'm > completely agnostic to which code style we use. =A0Perhaps Eclipse's > autoformatter's default setting would be a pragmatic choice. > > Charles Matthew > > > On Fri, Sep 17, 2010 at 1:55 AM, Henri Yandell wrote= : >> Not that I know - it's a classic way to start an argument :) >> >> General rules (of open source) are: >> >> * Adhere to the style of the file you're editing. >> * Don't commit sweeping reformatting with any other modification. >> * Don't impose your editor on others. >> * Just do it; aka 'at the end of the day we're volunteers, and someone >> who's prepared to do something generally has the moral advantage'. >> >> The main pain point I imagine are that if you do some work and hit >> ctrl-f (or whatever it is; I've not used Eclipse/Intellij for a long >> time :) ), and it reformats, then you need to load a clean version, >> reformat and then commit so your work and the reformatting aren't all >> mixed together. That's the main thing that will get tuts and >> complaints. :) >> >> Hen >> >> On Mon, Sep 13, 2010 at 6:23 AM, Charles Matthew Chen >> wrote: >>> Great, Sebb. >>> >>> =A0 =A0On a related note, I'm tempted to standardize the code formattin= g >>> of the entire project using something like Eclipse's autoformat >>> feature. =A0Is there a preferred code standard for Apache code? =A0Bett= er >>> yet, is there a pre-existing settings file for Eclipse's autoformat? >>> >>> Charles Matthew >>> >>> >>> On Thu, Sep 9, 2010 at 10:30 PM, sebb wrote: >>>> On 9 September 2010 20:56, Charles Matthew Chen wrote: >>>>> =A0 Sebb, please feel free to clean up warnings, etc. in Sanselan. >>>>> There's tons of code clean up that I'd like to do if I ever have time= . >>>> >>>> OK, thanks. >>>> >>>> I've now fixed the more obvious warnings. >>>> >>>> There are still a lot of unthrown Exceptions, but as the remaining >>>> ones are part of the public API I did not remove them yet. >>>> We should either document them (which prevents the Eclipse warning) or >>>> remove them, e.g. when 1.0 is released. >>>> >>>> Most of the code is infested with tabs (I'll start getting rid of the >>>> ones in the test code first). >>>> >>>>> =A0 +1 to have more active committers on Sanselan. >>>>> >>>>> Charles Matthew >>>>> >>>>> >>>>> On Wed, Sep 8, 2010 at 1:48 PM, Matt Benson wr= ote: >>>>>> For my part, I should think the community would be glad for someone = in addition to Charles to have his hands in sanselan. >>>>>> >>>>>> -Matt >>>>>> >>>>>> On Sep 8, 2010, at 11:37 AM, sebb wrote: >>>>>> >>>>>>> There are quite a few Eclipse warnings in the Sanselan test code. >>>>>>> >>>>>>> For example, test cases that declare impossible Exceptions. >>>>>>> Also potential null pointer exceptions that can be fixed either by: >>>>>>> - changing assertTrue(null !=3D value) to assertNotNull(value) >>>>>>> - or by explicitly checking for null >>>>>>> >>>>>>> Any objections if I just fix these? >>>>>>> >>>>>>> Or should I create a JIRA with patches first? >>>>>>> >>>>>>> -------------------------------------------------------------------= -- >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>>>> >>>>>> >>>>>> >>>>>> --------------------------------------------------------------------= - >>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>> For additional commands, e-mail: dev-help@commons.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org