commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Charles Matthew Chen <charlesmc...@gmail.com>
Subject Re: [SANSELAN] Fixing test case Eclipse warnings
Date Thu, 09 Sep 2010 19:56:07 GMT
   Sebb, please feel free to clean up warnings, etc. in Sanselan.
There's tons of code clean up that I'd like to do if I ever have time.

   +1 to have more active committers on Sanselan.

Charles Matthew


On Wed, Sep 8, 2010 at 1:48 PM, Matt Benson <gudnabrsam@gmail.com> wrote:
> For my part, I should think the community would be glad for someone in addition to Charles
to have his hands in sanselan.
>
> -Matt
>
> On Sep 8, 2010, at 11:37 AM, sebb wrote:
>
>> There are quite a few Eclipse warnings in the Sanselan test code.
>>
>> For example, test cases that declare impossible Exceptions.
>> Also potential null pointer exceptions that can be fixed either by:
>> - changing assertTrue(null != value) to assertNotNull(value)
>> - or by explicitly checking for null
>>
>> Any objections if I just fix these?
>>
>> Or should I create a JIRA with patches first?
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message