commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mikkel Meyer Andersen <m...@mikl.dk>
Subject [MATH] Updated: (MATH-384) DescriptiveStatistics based on double[]
Date Thu, 23 Sep 2010 08:36:23 GMT
Hi,

I've finally made a patch proposal for MATH-384 (
https://issues.apache.org/jira/browse/MATH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
) . Sorry for the delay.

What do you think?

Cheers, Mikkel.

---------- Forwarded message ----------
From: Mikkel Meyer Andersen (JIRA) <jira@apache.org>
Date: 2010/9/20
Subject: [jira] Commented: (MATH-384) DescriptiveStatistics based on double[]
To: mikl@mikl.dk



   [ https://issues.apache.org/jira/browse/MATH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912363#action_12912363
]

Mikkel Meyer Andersen commented on MATH-384:
--------------------------------------------

Lines 158-163 in the patch:
+       final int oldNumElements = numElements;
+
+       numElements += values.length;
+
+       int newSize = 0;
+       int i = 1;
should possibly be changed to
+       final int oldNumElements = numElements;
+
+       numElements += values.length;
+
+       int newSize = internalArray.length;
+       int i = 1;
to avoid looping if not necessary.

> DescriptiveStatistics based on double[]
> ---------------------------------------
>
>                 Key: MATH-384
>                 URL: https://issues.apache.org/jira/browse/MATH-384
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Mikkel Meyer Andersen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: patch-MATH-384-2, ResizableArrayInstantiatedByArray
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Right now the DescriptiveStatistics is for ResizableDoubleArray, but if the user has
the double[] data she wishes to get DescriptiveStatistics for there is no way of doing this
(besides the inefficient way of creating a ResizableDoubleArray from the double[]).
> It would be possible to use StatUtils, but it does not contain near as much functionality
as DescriptiveStatistics.
> Idea: Create a DescriptiveStatistics for double[] also. I'm not sure which way of implementing
it would be the best, but one way would be to make DescriptiveStatistics abstract with all
but the apply-method implemented as now. The apply-method should be made as abstract which
then has to implemented in the extensions together with a field containing the values. (addValue,
windowSize etc. has to go in the ResizableDoubleArray-extension.) The double[]-extension should
then have a constructor taking double[] as a parameter.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message