Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.216.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=mpXlv9I5vtk5lG7TUnfak2SGOEganLtKkiUX1Q8Hg90m2DMF6GfJRj4jJymXa1a4NZ
         35xJQbumKgTNSSQvBEENERmcnPSLPxkkzYbjP+M6hf1QnxhlLnBgpJsaOfIJdaRZtMZD
         ZpEBEz/7IdYaRr3Y04uoPfJGfOGI+Nd60HJHU=
MIME-Version: 1.0
In-Reply-To: <AANLkTim2QyUfaePXKo69EzGJjeRYswJwU1RejVmDLgZi@mail.gmail.com>
References: <AANLkTimZydx3QS8ENuDWxJvF+5OvffUrPLfsQB6k4HwO@mail.gmail.com>
	<AANLkTim2QyUfaePXKo69EzGJjeRYswJwU1RejVmDLgZi@mail.gmail.com>
Date: Sun, 8 Aug 2010 13:08:41 +0100
Message-ID: <AANLkTikNV0H95_PBdxCLgED3+3aaBwFz7i73W0aE-tK7@mail.gmail.com>
Subject: Re: LogFactory.getLog()
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 7 August 2010 06:00, James Carman <james@carmanconsulting.com> wrote:
> Attachments don't come through. =A0File a JIRA

+1 - please

>
> On Fri, Aug 6, 2010 at 10:11 PM, Doug Bateman <doug@dougbateman.net> wrot=
e:
>> Dear Commons Developers,
>>
>> Here's a suggestion for the commons-logging package...
>>
>> Presently, in Apache Commons, the most common way to get a logger is to =
do
>> something like:
>>
>> public class MyClass {
>> =A0=A0=A0 private static Log log =3D LogFactory.getLog(MyClass.class);
>> }
>>
>> Notice how MyClass.class (or alternatively a string name) is passed as a
>> parameter.=A0 The annoying aspect of this is that sometimes the class na=
me
>> doesn't get updated when doing copy/paste operations.=A0 A desirable
>> alternative might be:
>>
>> public class MyClass {
>> =A0=A0=A0 private static Log log =3D LogFactory.getLog(); //class name i=
nferred from
>> call stack
>> }
>>
>>
>> With such an approach there are two possible concerns I can foresee:
>>
>> Call stack inspection isn't terribly fast.=A0 However since Loggers are
>> generally initialized only once, when the class is first loaded, perform=
ance
>> isn't likely to be a major problem.
>> Commons-logging is Java 1.1 compatible.=A0 Thus care must be taken to en=
sure
>> compatibility isn't broken.
>> Commons-logging doesn't depend on commons-lang, and thus the utilities i=
n
>> commons-lang cannot be used.
>>
>> In Java 1.4, the call stack is easily obtained using Thread.getCallStack=
().

Huh?

I cannot find that method anywhere.

Do you perhaps mean

public StackTraceElement[] getStackTrace()

which is @since Java 1.5?

>> Prior to Java 1.4, the only way to obtain the call stack is to inspect t=
he
>> stack trace of an exception.
>>
>>
>> I've attached to this email a proof of concept implementation.=A0 It tes=
ts
>> successfully in Java 1.0+ and Java 1.4+.=A0 In order to ensure the
>> implementation doesn't break for Java 1.0, I used reflection to invoke t=
he
>> Java 1.4 APIs when they are available.
>>
>> Cheers,
>> Doug
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org