commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r983137 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java
Date Mon, 09 Aug 2010 01:52:26 GMT
On 8 August 2010 21:30, James Carman <james@carmanconsulting.com> wrote:
> On Sun, Aug 8, 2010 at 1:25 PM, sebb <sebbaz@gmail.com> wrote:
>>
>> Why is it safe to suppress warnings?
>>
>> If it is really necessary, please document why it is safe, e.g. as is
>> done in ArrayUtils.addAll()
>>
>
> It's safe because the code is making the assumption that the user
> isn't trying to do something stupid.

In which case, this assumption needs to be documented as a // comment
on the annotation.

Also the type requirements aren't even mentioned in the Javadoc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message