commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Fwd: svn commit: r983141 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
Date Sat, 07 Aug 2010 11:37:21 GMT
Hi James,

jcarman-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org wrote:

> Author: jcarman
> Date: Fri Aug  6 22:58:03 2010
> New Revision: 983141
> 
> URL: http://svn.apache.org/viewvc?rev=983141&view=rev
> Log:
> Removing some unnecessary boxing/casting/generics params
> 
> Modified:
>     
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
> 
> Modified:
> 
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
> URL:
> 
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java?rev=983141&r1=983140&r2=983141&view=diff
> 
==============================================================================

[snip]

> @@ -181,7 +181,7 @@ public class ArrayUtilsTest extends Test
>       */
>      public void testEmptyArrayCreation()
>      {
> -        final String[] array = ArrayUtils.<String>toArray();
> +        final String[] array = ArrayUtils.toArray();
>          assertEquals(0, array.length);
>      }
>  
> @@ -190,7 +190,7 @@ public class ArrayUtilsTest extends Test
>       */
>      public void testIndirectEmptyArrayCreation()
>      {
> -        final String[] array =
> ArrayUtilsTest.<String>toArrayPropagatingType();
> +        final String[] array = ArrayUtilsTest.toArrayPropagatingType();
>          assertEquals(0, array.length);
>      }

Can you please revert this? They are failing now. The provided generic type 
was exactly the reason for the test!

[snip]

- Jörg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message