Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates
 209.85.216.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=tOccyQdmJNGcAVjRblphevrbC6V0GmekQQQAB5n6vDkEzl2VLbWlKCg9kI/12Kg6cy
         cMFDZ2t3A046pAhGtuT2wa3SWXznarif0frSIyTK+8/sKSsu3/oO1eKir89efo9VE0Tz
         6Eu8VYR2cxGEJWYyFQ1P4dnOhYlVJbtRkNNVc=
MIME-Version: 1.0
In-Reply-To: <AANLkTinzZHbsrq_glk4339SkPXa2GeI9-ZSk7oZtplQV@mail.gmail.com>
References: <AANLkTikcUP5efuJpPETJYetWufdAoXpOxhjvYG2idzrn@mail.gmail.com>
	<AANLkTinzZHbsrq_glk4339SkPXa2GeI9-ZSk7oZtplQV@mail.gmail.com>
Date: Wed, 21 Jul 2010 08:23:59 -0700
Message-ID: <AANLkTil4nkSsyjCS6PInLf1sGJZwqIirQtCo5FtNmFBY@mail.gmail.com>
Subject: Re: [VOTE] Release Commons Lang 3.0 Beta.1
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thanks for the feedback sebb; comments inline:

On Wed, Jul 21, 2010 at 3:58 AM, sebb <sebbaz@gmail.com> wrote:
> On 21 July 2010 01:01, Henri Yandell <flamefew@gmail.com> wrote:
>> Context:
>>
>> =A0Releasing a beta version of the Lang 3.0 API for user feedback.
>> There aren't any major API changes expected, unless the community
>> raises them. The aim would be to _not_ put this in the Maven
>> repository.
>>
>> SVN tag:
>>
>> =A0 =A0http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_0=
_B1/
>>
>
> svn ps svn:eol-style native
> src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
> svn ps svn:eol-style native
> src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
>
> I could fix this but it would be better if the original author
> (ggregory) or at least someone using an OS with the same EOL =A0fixed
> the files (in trunk) to reduce commit noise.

Non-blocking, but something to fix. No idea what OS Gary uses :)

> What is the licence for the Spring Framework code mentioned in NOTICE?

Covered elsewhere in the thread.

> The file findbugs-exclude-filter.xml is missing from the source
> archive. This seems wrong.

Something to fix, I don't see it as blocking for a release as it would
only cause pain for someone generating the website.

> [The doap is also missing, but that is OK]

Agreed.

>> Signed downloads:
>>
>> =A0 =A0http://people.apache.org/~bayard/commons-lang-3.0-beta-1/
>
> No hashes, but I assume you would add those for a real release.

I was expecting to get them and didn't. Easy to create by hand but was
odd not to have Maven spitting them out.

>> Site:
>>
>> =A0 =A0http://people.apache.org/~bayard/commons-lang-3.0-beta-1/site/
>
> Still refers to 2.5 as the current release. Also says that the code is
> compatible with Java 1.3.

Website, so non-blocking. I'll work on a front page update.

>> Note that I've replace the clirr report with a more meaningful one for n=
ow:
>>
>> =A0 =A0http://people.apache.org/~bayard/commons-lang-3.0-beta-1/site/cli=
rr-report.html
>>
>> [ ] +1, let's see what people think
>> [X] -1, it's not ready yet
>
> Need to fix the missing file and LICENSE first, plus some other fixes
> I just made to trunk.

I don't see either of those being blocking. The missing file is minor
and the LICENSE doesn't need fixing.

> The Javadoc for TypeUtils refers to java.lang.NavigableSet, but that
> is @since 1.6.

Is that a Javadoc warning rather than fail?

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org