Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of rob.heittman@solertium.com
 designates 209.85.212.43 as permitted sender)
MIME-Version: 1.0
Date: Wed, 7 Jul 2010 20:47:43 -0400
Message-ID: <AANLkTikxh3YoK3sPSp6taQr_hUux-r9eflN876mZun3I@mail.gmail.com>
Subject: Behavior of DBCP 1.4 BasicDataSource setDriverClassLoader(...)
From: Rob Heittman <rob.heittman@solertium.com>
To: dev@commons.apache.org
Content-Type: multipart/alternative; boundary=0016e646410258c5eb048ad5a2d8

--0016e646410258c5eb048ad5a2d8
Content-Type: text/plain; charset=ISO-8859-1

Hi all,

It seems to me that the 1.4 behavior of BasicDataSource with regard to
setDriverClassLoader(...) is slightly off.  In my case -- using this to
enable DBCP to work better under some OSGi environments -- it doesn't have
the desired effect.  In createConnectionFactory() we have, essentially

            if (driverFromCCL == null) {
                // use DriverManager, which doesn't respect
driverClassLoader
                driver = DriverManager.getDriver(url);
            } else {
                // ... use the CCL to make our own Driver ...
            }

It's simple enough in my project to override createConnectionFactory(), but
wouldn't it be more predictable to do something like this?

            if (driverClassLoader !=null) {
                // ... use driverClassLoader to make our own Driver ...
            } else if (driverFromCCL == null) {
                // use a method that doesn't respect driverClassLoader
                driver = DriverManager.getDriver(url);
            } else {
                // ... use the CCL to make our own Driver ...
            }

Alternatively, a couple stanzas higher, we could set driverFromCCL if
driverClassLoader is used, which would trigger the correct behavior in this
(unmodified) section.

It seems like if somebody goes to the trouble to setDriverClassLoader(...)
they expect it to be used to load driver classes.  (I did)  If wiser heads
agree, happy to send a patch.

- Rob

--0016e646410258c5eb048ad5a2d8--