Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 78895 invoked from network); 28 Apr 2010 08:16:12 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Apr 2010 08:16:12 -0000 Received: (qmail 83674 invoked by uid 500); 28 Apr 2010 08:16:12 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 83436 invoked by uid 500); 28 Apr 2010 08:16:09 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 83417 invoked by uid 99); 28 Apr 2010 08:16:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 08:16:08 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [194.126.102.184] (HELO mx6.playtech.com) (194.126.102.184) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 08:15:59 +0000 Received: from localhost (amavis [192.168.8.218]) by mx6int.playtech.com (Postfix) with ESMTP id 5D4053CA4DD for ; Wed, 28 Apr 2010 11:15:39 +0300 (EEST) X-Virus-Scanned: amavisd-new at playtech.com Received: from mx6.playtech.com ([192.168.2.224]) by localhost (mail1.playtech.com [192.168.8.218]) (amavisd-new, port 11024) with ESMTP id Wu9no5iJY-cG for ; Wed, 28 Apr 2010 11:15:39 +0300 (EEST) Received: from ee-exch1.EE.playtech.corp (unknown [192.168.3.25]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx6.playtech.com (Postfix) with ESMTP id ED3E23CA4DC for ; Wed, 28 Apr 2010 11:15:38 +0300 (EEST) Received: from ee-exch1.EE.playtech.corp ([192.168.3.25]) by ee-exch1.EE.playtech.corp ([192.168.3.25]) with mapi; Wed, 28 Apr 2010 11:15:38 +0300 From: Kaarel Kann To: "dev@commons.apache.org" CC: Reimo Daum Date: Wed, 28 Apr 2010 11:15:37 +0300 Subject: [net] TelnetInputStream.java: escaping byte 255 Thread-Topic: [net] TelnetInputStream.java: escaping byte 255 Thread-Index: AcrmqvrVs6FY+h5RQp+KMsgVNXN3hA== Message-ID: Accept-Language: en-US, et-EE Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: acceptlanguage: en-US, et-EE Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_006E_01CAE6C4.20E41F00" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org ------=_NextPart_000_006E_01CAE6C4.20E41F00 Content-Type: multipart/mixed; boundary="----=_NextPart_001_006F_01CAE6C4.20E41F00" ------=_NextPart_001_006F_01CAE6C4.20E41F00 Content-Type: multipart/alternative; boundary="----=_NextPart_002_0070_01CAE6C4.20E41F00" ------=_NextPart_002_0070_01CAE6C4.20E41F00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, We ran into a problem of sending 255 over network. It is escaped by another 255 (as specified by RFC854) but TelnetInputStream.java:196 (from revision 658491) breaks the wrong switch and actually next byte is also ignored. Can you confirm that this is actually a bug or is it done deliberately? Attached patch. Kaarel Kann ------=_NextPart_002_0070_01CAE6C4.20E41F00 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi,

We ran into a problem of sending = 255 over network. It is escaped by another 255 (as specified by RFC854) but = TelnetInputStream.java:196 (from revision 658491) breaks the wrong switch and actually next byte is = also ignored.

Can you confirm that this is = actually a bug or is it done deliberately?

Attached = patch.

Kaarel Kann

------=_NextPart_002_0070_01CAE6C4.20E41F00-- ------=_NextPart_001_006F_01CAE6C4.20E41F00 Content-Type: application/octet-stream; name="IAC.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="IAC.patch" Index: TelnetInputStream.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- TelnetInputStream.java (revision 938810) +++ TelnetInputStream.java (working copy) @@ -193,7 +193,7 @@ /* TERMINAL-TYPE option (end)*/=0A= case TelnetCommand.IAC:=0A= __receiveState =3D _STATE_DATA;=0A= - break;=0A= + break _mainSwitch;=0A= default:=0A= break;=0A= }=0A= ------=_NextPart_001_006F_01CAE6C4.20E41F00-- ------=_NextPart_000_006E_01CAE6C4.20E41F00 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKJTCCAwMw ggJsAhEAuS9gzIifoXpGCbhbcGyKrzANBgkqhkiG9w0BAQUFADCBwTELMAkGA1UEBhMCVVMxFzAV BgNVBAoTDlZlcmlTaWduLCBJbmMuMTwwOgYDVQQLEzNDbGFzcyAyIFB1YmxpYyBQcmltYXJ5IENl cnRpZmljYXRpb24gQXV0aG9yaXR5IC0gRzIxOjA4BgNVBAsTMShjKSAxOTk4IFZlcmlTaWduLCBJ bmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5l dHdvcmswHhcNOTgwNTE4MDAwMDAwWhcNMjgwODAxMjM1OTU5WjCBwTELMAkGA1UEBhMCVVMxFzAV BgNVBAoTDlZlcmlTaWduLCBJbmMuMTwwOgYDVQQLEzNDbGFzcyAyIFB1YmxpYyBQcmltYXJ5IENl cnRpZmljYXRpb24gQXV0aG9yaXR5IC0gRzIxOjA4BgNVBAsTMShjKSAxOTk4IFZlcmlTaWduLCBJ bmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5l dHdvcmswgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAKeIASF0LOcaA/CY4Zc8DyEI8Zzbl+ma /MIEBhO+X1LIzB4sElYsuAFpLMyZH62wlq55BPITOcF7mLoILOjChBMsqmnpCfTHqQKkQsIjT0rY 8A6i+zFsyeZvmScH9eb0THiebetGhvq5hslU8rLEr9RGHFrJFTD/DWz1LQ5tzn93AgMBAAEwDQYJ KoZIhvcNAQEFBQADgYEAci75f9HxcfvEnvbFXlGKQJi4aPibHIPY4p29/+2h5mbqLwn0ytfqpSuV 9iRghk1ELoOlxC2g0654aW9y2myuCPBjkjfmu8QwF613zEk1qs/Yj9G+txiWR3NqVCI0ZC22FptZ W7RRWTqzCxT0Et9noPStMmResUZyJ4wSe8VEtK4wggN0MIIC3aADAgECAhBBdmWMh5jqbe70iWHh AQsNMA0GCSqGSIb3DQEBBQUAMIGrMRQwEgYDVQQKEwtBZGFjb20gUy5BLjEfMB0GA1UECxMWVmVy aVNpZ24gVHJ1c3QgTmV0d29yazE5MDcGA1UECxMwVGVybXMgb2YgdXNlIGF0IGh0dHBzOi8vc2Vj LmFkYWNvbS5jb20vcnBhIChjKTAwMTcwNQYDVQQDEy5BZGFjb20gQ2xhc3MgMiBPblNpdGUgSW5k aXZpZHVhbCBTdWJzY3JpYmVyIENBMB4XDTA5MDgyODAwMDAwMFoXDTEwMDgyODIzNTk1OVowgY0x IjAgBgNVBAoMGVBsYXl0ZWNoIFNvZnR3YXJlIExpbWl0ZWQxCzAJBgNVBAsMAklUMRswGQYDVQQL DBJzZWMuYWRhY29tLmNvbS9ycGExFDASBgNVBAMMC0thYXJlbCBLYW5uMScwJQYJKoZIhvcNAQkB FhhrYWFyZWwua2FubkBwbGF5dGVjaC5jb20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANEB fgnAYqokQGSUcQkCjm+sy0SaSUlLZz1TEqgjIwdT8QqXd2nu6fzR8cM6Cs8VgUaslcgdQlO57/Br uyUrumSVI4ZuljxBJP5SSnf8QBazy1bw33MR792q5/JXe5lVmaS9f6m1oyRkKfCJTjEvxsUe9F/y /EDZu0Wk1x3hGPQ/AgMBAAGjgbQwgbEwCQYDVR0TBAIwADBBBgNVHSAEOjA4MDYGCmCGSAGG+EUB BxowKDAmBggrBgEFBQcCARYaaHR0cHM6Ly9zZWMuYWRhY29tLmNvbS9ycGEwCwYDVR0PBAQDAgWg MBEGCWCGSAGG+EIBAQQEAwIHgDBBBgNVHR8EOjA4MDagNKAyhjBodHRwOi8vY3JsLmFkYWNvbS5j b20vT25TaXRlUHVibGljL0xhdGVzdENSTC5jcmwwDQYJKoZIhvcNAQEFBQADgYEAtO5E0mDx2ij7 p4MHUAcElB6KHNTZyLyEWDLwz36ZMCrEBncFNeN8zK9AhG5Y4DqIQmxN8drsI9tqqev4MNVeEJeJ aWMUJsu5yuSCKTDsJcvW1ifudIXR9upXCOBTsl/7AnHSO+C0Chg2DB+57QxMzby5NY7vRcZZ6YAg O1CPvG0wggOiMIIDC6ADAgECAhBECvMJTOtOPNLdKYuDelCJMA0GCSqGSIb3DQEBBQUAMIHBMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xPDA6BgNVBAsTM0NsYXNzIDIgUHVi bGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMjE6MDgGA1UECxMxKGMpIDE5 OTggVmVyaVNpZ24sIEluYy4gLSBGb3IgYXV0aG9yaXplZCB1c2Ugb25seTEfMB0GA1UECxMWVmVy aVNpZ24gVHJ1c3QgTmV0d29yazAeFw0wMDA4MjAwMDAwMDBaFw0xMTA4MTkyMzU5NTlaMIGrMRQw EgYDVQQKEwtBZGFjb20gUy5BLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE5MDcG A1UECxMwVGVybXMgb2YgdXNlIGF0IGh0dHBzOi8vc2VjLmFkYWNvbS5jb20vcnBhIChjKTAwMTcw NQYDVQQDEy5BZGFjb20gQ2xhc3MgMiBPblNpdGUgSW5kaXZpZHVhbCBTdWJzY3JpYmVyIENBMIGf MA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDNNBG4BUKGHfD9XjgTIsscGWYKFkKbSi4gM3d0Cik1 SG2DoxO88uzepMutsehB1t3vH5y89WkfrcgyEgvOV8KRWZ7priOmkyUAB4UJo7SGui20pi3bf0Yt bXIfir4b6g5s3GleHss6IMOfv+D2O7R/Ny/CYd4m8jOmn19k4t2cXQIDAQABo4GuMIGrMBEGCWCG SAGG+EIBAQQEAwIBBjAPBgNVHRMECDAGAQH/AgEAMAsGA1UdDwQEAwIBBjBCBgNVHSAEOzA5MDcG C2CGSAGG+EUBBxcCMCgwJgYIKwYBBQUHAgEWGmh0dHBzOi8vc2VjLmFkYWNvbS5jb20vcnBhMDQG A1UdHwQtMCswKaAnoCWGI2h0dHA6Ly9jcmwudmVyaXNpZ24uY29tL3BjYTItZzIuY3JsMA0GCSqG SIb3DQEBBQUAA4GBAEvUanZnObGNbgBSvU8ZfWZelFtN8AxnBgGrCCpEfh/81gxaZMLFho98gVQS C5Rv/KOFYe84Wpmhq7SA6bM7Sv6UuiKYX9IVdLYUONgNTgvTYQotQevOU7IWfeAYVkTy3PzyWN+9 E2uqLIiIzSgftVX0Kb3iO/uG/sfrOQyFxqZhMYID2zCCA9cCAQEwgcAwgasxFDASBgNVBAoTC0Fk YWNvbSBTLkEuMR8wHQYDVQQLExZWZXJpU2lnbiBUcnVzdCBOZXR3b3JrMTkwNwYDVQQLEzBUZXJt cyBvZiB1c2UgYXQgaHR0cHM6Ly9zZWMuYWRhY29tLmNvbS9ycGEgKGMpMDAxNzA1BgNVBAMTLkFk YWNvbSBDbGFzcyAyIE9uU2l0ZSBJbmRpdmlkdWFsIFN1YnNjcmliZXIgQ0ECEEF2ZYyHmOpt7vSJ YeEBCw0wCQYFKw4DAhoFAKCCAnAwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0B CQUxDxcNMTAwNDI4MDgxNTM3WjAjBgkqhkiG9w0BCQQxFgQUahb2ZwMkqCtX6hqT02MxCW4PHoow ZwYJKoZIhvcNAQkPMVowWDAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwIC AUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwBwYFKw4DAhowCgYIKoZIhvcNAgUwgdEGCSsGAQQB gjcQBDGBwzCBwDCBqzEUMBIGA1UEChMLQWRhY29tIFMuQS4xHzAdBgNVBAsTFlZlcmlTaWduIFRy dXN0IE5ldHdvcmsxOTA3BgNVBAsTMFRlcm1zIG9mIHVzZSBhdCBodHRwczovL3NlYy5hZGFjb20u Y29tL3JwYSAoYykwMDE3MDUGA1UEAxMuQWRhY29tIENsYXNzIDIgT25TaXRlIEluZGl2aWR1YWwg U3Vic2NyaWJlciBDQQIQQXZljIeY6m3u9Ilh4QELDTCB0wYLKoZIhvcNAQkQAgsxgcOggcAwgasx FDASBgNVBAoTC0FkYWNvbSBTLkEuMR8wHQYDVQQLExZWZXJpU2lnbiBUcnVzdCBOZXR3b3JrMTkw NwYDVQQLEzBUZXJtcyBvZiB1c2UgYXQgaHR0cHM6Ly9zZWMuYWRhY29tLmNvbS9ycGEgKGMpMDAx NzA1BgNVBAMTLkFkYWNvbSBDbGFzcyAyIE9uU2l0ZSBJbmRpdmlkdWFsIFN1YnNjcmliZXIgQ0EC EEF2ZYyHmOpt7vSJYeEBCw0wDQYJKoZIhvcNAQEBBQAEgYB5H79grmBYkBjHbLmWSJLLsR0f5bGl aUt3fspPUhOIN1QqoLTMfkdn8hiAZkqOEgWY0MPigWb8ADS0lItjzczO7msZzMBTgWlKEP3Nm+f8 x7v4A3FRLqvxU3h2SwUWA5iqDfLPNe7bQwhEaHjwtIbTxc1n0/Qo60TWrz5qYz+CugAAAAAAAA== ------=_NextPart_000_006E_01CAE6C4.20E41F00--