Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of niall.pemberton@gmail.com
 designates 209.85.220.218 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=XrCibuAqhGZ5wnZIR6wRhAVQwn32lOvoMv8EikhwnkUbQIcYCHx+PjZmVsZlxTIrYu
         fO3OlTm7BEQ+B+HlIIRraf6xjOrKwdYEYp77BNiCYhV33IaOU0DVY1QahmQgLOlgfASf
         Xz94OM9GS5/bNL9oT7pGsFMyxvDZ4aAZ4UzoY=
MIME-Version: 1.0
In-Reply-To: <25aac9fc1003101615j78664c62vdcc2979702c89d56@mail.gmail.com>
References: <55afdc851003081742l281c7e43x54ed41e4e15dd749@mail.gmail.com>
	 <hn5hrt$c2p$2@dough.gmane.org>
	 <55afdc851003091721j4eec2a01nf38ba6f52cda7e15@mail.gmail.com>
	 <25aac9fc1003101534t7af36b53ia4bfd9501b0e0b54@mail.gmail.com>
	 <55afdc851003101603jba23375s6b6f6bcccb3f18dd@mail.gmail.com>
	 <25aac9fc1003101615j78664c62vdcc2979702c89d56@mail.gmail.com>
Date: Thu, 11 Mar 2010 01:04:44 +0000
Message-ID: <55afdc851003101704n3ea3caacm9e792ef9f268c612@mail.gmail.com>
Subject: Re: [all] commons-parent-13 problems
From: Niall Pemberton <niall.pemberton@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 11, 2010 at 12:15 AM, sebb <sebbaz@gmail.com> wrote:
> On 11/03/2010, Niall Pemberton <niall.pemberton@gmail.com> wrote:
>> On Wed, Mar 10, 2010 at 11:34 PM, sebb <sebbaz@gmail.com> wrote:
>> =A0> On 10/03/2010, Niall Pemberton <niall.pemberton@gmail.com> wrote:
>> =A0>> On Tue, Mar 9, 2010 at 1:18 PM, J=F6rg Schaible <joerg.schaible@gm=
x.de> wrote:
>> =A0>> =A0> Hi Niall,
>> =A0>> =A0>
>> =A0>> =A0> Niall Pemberton wrote at Dienstag, 9. M=E4rz 2010 02:42:
>> =A0>> =A0>
>> =A0>> =A0>> Unfortunately the upgrade of the maven-site-plugin from 2.0.=
1 to 2.1
>> =A0>> =A0>> has caused the site generation for Chain, Configuration and =
DBCP to
>> =A0>> =A0>> now fail. I'm looking into this to see whether its something=
 we can
>> =A0>> =A0>> fix in the components or whether we need to downgrade the si=
te plugin
>> =A0>> =A0>> version.
>> =A0>> =A0>>
>> =A0>> =A0>> I have reverted the maven-bundle-plugin version to 1.4.3 and=
 the
>> =A0>> =A0>> maven-remote-resources-plugin to 1.0 (version 1.1 inherited =
from
>> =A0>> =A0>> apache parent 7) - this restores JDK 1.4 compatibility for "=
mvn
>> =A0>> =A0>> package/install".
>> =A0>> =A0>
>> =A0>> =A0> Did you give the animal-sniffer a try?
>> =A0>>
>> =A0>>
>> =A0>> No, but this is more Sebb's thing. I think its still a good idea t=
o
>> =A0>> =A0build/test on the target JDK when checking out a release. Which=
 is
>> =A0>> =A0what I did for Lang 2.5 and Beanutiles 1.8.x
>> =A0>
>> =A0> I am working on a fix for the parent pom which allows the compile &
>> =A0> test to be run under a different JVM than Maven itself.
>> =A0>
>> =A0> The proposed fix is to add profiles for Java 1.3 and Java 1.4 (even
>> =A0> Java 1.5); these profiles are used to tweak the compiler and surefi=
re
>> =A0> plugin configurations.
>>
>>
>> I haven't tried this out but perhaps it could be done with one new
>> =A0profile and four properties. In the new profile in the parent pom use
>> =A0something like:
>>
>> =A0 =A0 =A0<plugin>
>> =A0 =A0 =A0 =A0<artifactId>maven-compiler-plugin</artifactId>
>> =A0 =A0 =A0 =A0<configuration>
>> =A0 =A0 =A0 =A0 =A0<executable>${commons.java.home}/bin/javac</executabl=
e>
>> =A0 =A0 =A0 =A0</configuration>
>> =A0 =A0 =A0</plugin>
>>
>> =A0In a component that requires JDK 1.3 have:
>> =A0 =A0 <properties>
>> =A0 =A0 =A0 =A0 <commons.java.home>${JAVA_1_3_HOME}</commons.java.home>
>> =A0 =A0 </properties>
>>
>> =A0In a component that requires JDK 1.4 have:
>> =A0 =A0 <properties>
>> =A0 =A0 =A0 =A0 <commons.java.home>${JAVA_1_4_HOME}</commons.java.home>
>> =A0 =A0 </properties>
>>
>> =A0In a component that requires JDK 1.5 have:
>> =A0 =A0 <properties>
>> =A0 =A0 =A0 =A0 <commons.java.home>${JAVA_1_5_HOME}</commons.java.home>
>> =A0 =A0 </properties>
>>
>> =A0Then locally developers just need to configure JAVA_1_3_HOME,
>> =A0JAVA_1_4_HOME, JAVA_1_5_HOME in their settings.xml and they can then
>> =A0build the component with the target JDK version.
>>
>
> One of the problems is that the Surefire plugin needs to run under the
> target version of Java; this means downgrading the version for Java
> 1.3.
>
> Also, by having separate profiles for each JVM version, one can build
> LANG with Java 1.3, 1.4, and 1.5 whilst running Maven under Java 1.6.
>
> Furthermore, there is no need to update the component poms.

Good points.

Niall

>> =A0Niall
>>
>>
>> =A0> By default the build would use the same JVM as Maven - i.e. same as=
 at
>> =A0> present - but if the user has installed other versions of the JVM,
>> =A0> they can define the JVM locations (e.g. in settings.xml) and enable
>> =A0> the appropriate JVM using the relevant profile.
>> =A0>
>> =A0> I think this should address all the requirements we have.
>> =A0>
>> =A0>>
>> =A0>> =A0Niall
>> =A0>>
>> =A0>>
>> =A0>> =A0>>
>> =A0>> =A0>> http://svn.apache.org/viewvc?view=3Drevision&revision=3D9206=
07
>> =A0>> =A0>>
>> =A0>> =A0>> maven-site-plugin 2.1 requires maven 2.1 to run (which AFAIK=
 needs JDK
>> =A0>> =A0>> 1.5) - so currently the site won't generate using JDK 1.4 - =
reverting
>> =A0>> =A0>> to 2.0.1 of the site plugin is required to run under JDK 1.4=
 - do we
>> =A0>> =A0>> need that?
>> =A0>> =A0>>
>> =A0>> =A0>> Also I noticed in the apache parent the following comment fo=
r the
>> =A0>> =A0>> maven-javadoc-plugin:
>> =A0>> =A0>> =A0 =A0"NOTE: 2.6.x is generally unusuable due to MJAVADOC-2=
75"
>> =A0>> =A0>> =A0 =A0 http://jira.codehaus.org/browse/MJAVADOC-275
>> =A0>> =A0>>
>> =A0>> =A0>> So probably we should revert to 2.5 for the javadoc plugin
>> =A0>> =A0>
>> =A0>> =A0> You have to here :-/
>> =A0>> =A0>
>> =A0>> =A0> - J=F6rg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org