Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of GGregory@seagullsoftware.com
 designates 216.82.242.131 as permitted sender)
From: Gary Gregory <GGregory@seagullsoftware.com>
To: Commons Developers List <dev@commons.apache.org>
Subject: RE: svn commit: r928129 -
 /commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java
Thread-Topic: svn commit: r928129 -
 /commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java
Thread-Index: AQHKzVuPR1en1N7sT0KUVXlCQHWus5IFgxqA///LubA=
Date: Sat, 27 Mar 2010 06:14:53 +0000
Message-ID: 
 <02AA127CD8DCDE48BC7D2DFB6C87083A0C3185@nwt-s-mbx1.rocketsoftware.com>
References: <20100327031341.D4A6523889E2@eris.apache.org>
 <598ad5b51003262221s4c8898c0q9cb1b769e75e23ba@mail.gmail.com>
In-Reply-To: <598ad5b51003262221s4c8898c0q9cb1b769e75e23ba@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Ah, yes, good catch.=20
Thank you,
Gary
> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Friday, March 26, 2010 22:22
> To: dev@commons.apache.org
> Subject: Re: svn commit: r928129 -
> /commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Ba
> se64Test.java
>=20
> Hi,
>=20
> I think there's a mistake here (even though it's commented out):
>=20
> //assertEquals("foo",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm9v" +
> Base64.CHUNK_SEPARATOR)));
>=20
>=20
> Consider output of following:
>=20
>         String s =3D "Zm9v" + Base64.CHUNK_SEPARATOR;
>         System.out.println(s);
>=20
> The output is:
>=20
>         Zm9v[B@6bbc4459
>=20
>=20
> I've attached a fix to CODEC-99 as 'codec-99-test-fixes.patch'.
>=20
>=20
> yours,
>=20
> Julius
>=20
>=20
> > + =A0 =A0public void testRfc4648Section10DecodeWithCrLf() {
> > + =A0 =A0 =A0 =A0assertEquals("",
> StringUtils.newStringUsAscii(Base64.decodeBase64("")));
> > + =A0 =A0 =A0 =A0assertEquals("f",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zg=3D=3D" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0 =A0 =A0assertEquals("fo",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm8=3D" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0 =A0 =A0//assertEquals("foo",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm9v" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0 =A0 =A0assertEquals("foob",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm9vYg=3D=3D" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0 =A0 =A0assertEquals("fooba",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm9vYmE=3D" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0 =A0 =A0//assertEquals("foobar",
> StringUtils.newStringUsAscii(Base64.decodeBase64("Zm9vYmFy" +
> Base64.CHUNK_SEPARATOR)));
> > + =A0 =A0}
> > +
>=20
>=20
>=20
> --
> yours,
>=20
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
>=20
> $ sudo apt-get install cowsay
> $ echo "Moo." | cowsay | cowsay -n | cowsay -n
> http://juliusdavies.ca/cowsay/
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org