commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niall Pemberton <niall.pember...@gmail.com>
Subject Re: svn commit: r927470 - in /commons/proper/net/branches/NET_2_0: pom.xml src/main/resources/ src/main/resources/templates/math-release-notes.vm src/main/resources/templates/release-notes.vm
Date Thu, 25 Mar 2010 17:01:48 GMT
IMO its a mistake to put the template in src/main/resources/templates

Its only because we have <resources> elements defined in
commons-parent for the NOTICE & LICENSE file that this template is not
copied into the project's jar file - if, for example, we move to use
the remote-resources-plugin and removed those elements from
commons-parent that could happen - or the project decides to add other
resources they want included in the jar - then that would be the
natural (maven) place to put them.

Much better to put it in the src/changes directory which is more appropriate.

Also are the Net devs ever going to use the changes plugin to generate
release notes? If not then its a bit pointless adding it as well.

Niall

On Thu, Mar 25, 2010 at 4:17 PM,  <sebb@apache.org> wrote:
> Author: sebb
> Date: Thu Mar 25 16:17:16 2010
> New Revision: 927470
>
> URL: http://svn.apache.org/viewvc?rev=927470&view=rev
> Log:
> Copy release-notes velocity template from Commons Math
>
> Added:
>    commons/proper/net/branches/NET_2_0/src/main/resources/
>      - copied from r926867, commons/proper/math/trunk/src/main/resources/
>    commons/proper/net/branches/NET_2_0/src/main/resources/templates/release-notes.vm
>      - copied unchanged from r926867, commons/proper/math/trunk/src/main/resources/templates/math-release-notes.vm
> Removed:
>    commons/proper/net/branches/NET_2_0/src/main/resources/templates/math-release-notes.vm
> Modified:
>    commons/proper/net/branches/NET_2_0/pom.xml
>
> Modified: commons/proper/net/branches/NET_2_0/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/pom.xml?rev=927470&r1=927469&r2=927470&view=diff
> ==============================================================================
> --- commons/proper/net/branches/NET_2_0/pom.xml (original)
> +++ commons/proper/net/branches/NET_2_0/pom.xml Thu Mar 25 16:17:16 2010
> @@ -248,6 +248,8 @@ limitations under the License.
>                     <issueLinkTemplatePerSystem>
>                         <default>%URL%/%ISSUE%</default>
>                     </issueLinkTemplatePerSystem>
> +                    <template>release-notes.vm</template>
> +                    <templateDirectory>templates</templateDirectory>
>                 </configuration>
>                 <reportSets>
>                     <reportSet>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message