commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject [compress] Dealing with "invalid" extra fields in ZIPs
Date Fri, 12 Feb 2010 14:13:05 GMT

in ZIP files each entry can be associated with "extra data" for
extension stuff, this is available via ZipEntry#getExtra and

The semi-official ZIP standard recommends a format for this extra data
(two-byte tag, two-byte length of data, rest of data) and the current
ZIP classes in compress go a step further and enforce this

There are files out there that contain extra fields that do not follow
the recommendation.  You can find one attached to COMPRESS-62.

When reading such a file InfoZIP's unzip simply ignores the extra fields
and issues a warning.  Our ZipFile and ZipArchiveEntry classes throw an

It wouldn't be too difficult to make the codebase ignore those fields as
well, but there are a few things to consider:

* currently the Javadocs of ZipArchiveEntry#setExtra says "Throws an
  Exception if extra data cannot be parsed into extra fields."

  Either we change the Javadocs or we add a different method that does
  not throw an exceptions, I'm not sure.

* do we want to log a warning?  Where to?

* do we want to accept invalid extra fields when writing ZIP entries as


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message