commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Daemon 1.0.2 based on RC2
Date Wed, 24 Feb 2010 16:22:03 GMT
On 24/02/2010, Bill Barker <billwbarker@verizon.net> wrote:
>
>
>  --------------------------------------------------
>  From: "sebb" <sebbaz@gmail.com>
>  Sent: Tuesday, February 23, 2010 5:44 PM
>  To: "Commons Developers List" <dev@commons.apache.org>
>  Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC2
>
>
> > On 24/02/2010, Bill Barker <billwbarker@verizon.net> wrote:
> >
> > >
> > >
> > >  --------------------------------------------------
> > >  From: "Mladen Turk" <mturk@apache.org>
> > >  Sent: Tuesday, February 23, 2010 4:08 AM
> > >  To: "Commons Developers List" <dev@commons.apache.org>
> > >  Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC2
> > >
> > >
> > > > On 02/23/2010 01:04 PM, sebb wrote:
> > > >
> > > > > On 23/02/2010, Mladen Turk<mturk@apache.org>  wrote:
> > > > >
> > > > > > Daemon RC2 fixes some minor distribution issues over the
> > > > > >  previous RC1 proposal.
> > > > > >
> > > > > >  RC2 Release is here:
> > > > > >  http://people.apache.org/~mturk/daemon/
> > > > > >  Tag is here:
> > > > > >
> > >
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC2/
> > > > > >
> > > > >
> > > > > -1 because:
> > > > >
> > > > > There are still some files without AL headers:
> > > > >
> > > > >
> > > >
> > > > I won't add them because they are not needed.
> > > > This is really getting to look like a nit-picking to me :(
> > > >
> > > >
> > >
> > >  I agree with Mladen, the headers aren't needed in these files.  There
> is
> > > zero creative content in any of these files (they are
> machine-generated).
> > >
> > >
> >
> > Are you sure they are all machine-generated?
> > What application generates them?
> >
> >
>
>  The three Makefiles might be hand generated, and I can't be bothered to
> sift through the Tomcat archives to find out.  I've added headers to them,
> but they should be considered for removal, since I can't see that you would
> get more than a partially functioning program if you used them.  Of course,
> they build the deprecated Windows service wrapper, which should also be
> considered for removal at some point.
>
>  The files under the procrun directory are generated by Microsoft Developer
> Studio using the "Export Makefile" option.  They are just a machine
> translation of the information in the corresponding .dsp file, provided to
> allow someone to build procrun if they only have the MS-SDK installed
> instead of the full Developer Studio.  As such, they can't be copywrited,
> and would be impossible to maintain (since the header would get erased every
> time they are updated).
>

OK, thanks for the information. That's very useful to know.
Might be useful to add it to the README file at some point.

I raised the issue because the RAT report showed that several files
did not have headers.
It was not obvious to me at the time that these were generated files.

I withdraw my objection to the missing AL headers; as you say, it
would not be appropriate to add them to the exported files.

>
> > Note that I've not included the .rc files which have the heading:
> > //Microsoft Developer Studio generated resource script
> >
> >
> > >
> > > >
> > > > Regards
> > > > --
> > > > ^TM
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> > > dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> > >
> > >
> ---------------------------------------------------------------------
> > >  To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> > >  For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message