Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 65410 invoked from network); 27 Jan 2010 19:42:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Jan 2010 19:42:44 -0000 Received: (qmail 50467 invoked by uid 500); 27 Jan 2010 19:42:44 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 50349 invoked by uid 500); 27 Jan 2010 19:42:43 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 50339 invoked by uid 99); 27 Jan 2010 19:42:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2010 19:42:43 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com designates 209.85.219.215 as permitted sender) Received: from [209.85.219.215] (HELO mail-ew0-f215.google.com) (209.85.219.215) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2010 19:42:35 +0000 Received: by ewy7 with SMTP id 7so1047562ewy.10 for ; Wed, 27 Jan 2010 11:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=v3uU3TSgKHT1gA7yHk7Au7xIu2t4l17/hoIkvgkW4mc=; b=nOJM1oDKFVSN6+YRyoyskeLwyTquC62QGUkkWv1WoYfjIz1pl/nEQz5SIuZKekowsv ORJFGwIXGmON4mSzNGzj6uPgDj7/bqr8C1jDoTQg2YJbS/G59Cloomh7rbbWoYTPfCrh 0CCJDyi/URwkcsQBKBHGU1CcYkF4wi3+qONCk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=hmlGpCOVQ95VNXr3wzHviPbKu9TCPe37oS2bwP3XqjHmoX5f9ZlMUVj9OKyDaAPPiZ xuXsd1/WRf1R/ysmHh3pN4X3q/lomYx3NeX0kqV8bWP5HWxKUosTvo82BFuAkuwmTSdN hHObfylAT1clMvOCfxpzlmAH3HGJC5zL3pudQ= MIME-Version: 1.0 Received: by 10.213.41.3 with SMTP id m3mr6687329ebe.39.1264621335184; Wed, 27 Jan 2010 11:42:15 -0800 (PST) In-Reply-To: <25aac9fc1001270924l75868fe9vf682dad77c5fa4ef@mail.gmail.com> References: <25aac9fc1001270924l75868fe9vf682dad77c5fa4ef@mail.gmail.com> Date: Wed, 27 Jan 2010 20:42:14 +0100 Message-ID: <4173dc211001271142o4c2e1e10if98e025133db35da@mail.gmail.com> Subject: Re: [DIGESTER-AT] FromAnnotationsRuleSet could be immutable? From: Simone Tripodi To: Commons Developers List Content-Type: multipart/alternative; boundary=00148530ad55758972047e2a9983 X-Virus-Checked: Checked by ClamAV on apache.org --00148530ad55758972047e2a9983 Content-Type: text/plain; charset=UTF-8 Hi Sebb, your suggestions are like water in the middle of the Sahara, thanks a *lot*, this is a very god catch! Very very appreciated!!! I'm going to make it volatile, thanks again :) Simo http://people.apache.org/~simonetripodi/ On Wed, Jan 27, 2010 at 6:24 PM, sebb wrote: > As far as I can tell, FromAnnotationsRuleSet is currently the only > mutable class in the annotations packages, and that mutability is only > because of the setNameSpaceURI() method. > > Would it be possible to make the URI a constructor parameter instead? > > If not, perhaps consider whether to make the String field volatile. > This would make all the classes thread-safe. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --00148530ad55758972047e2a9983--