Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.220.217 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=HPOngq1923d6KmFtag0lazeNRFbWzVCm4fCBXGr3hcxxqswQstq12E6og2+iU59fzZ
         fKglifbrE/0//INzTKH8koTDUZYKQck0IKijwHPcBbCwYQFArKBhTZ7qcZqoeo0AOJaC
         xkNyuGQ8ALi64kcR47BOnzoPg+IRz+tnBu9Eo=
MIME-Version: 1.0
In-Reply-To: <4B447390.8040701@gmail.com>
References: <25aac9fc1001050311i3f969f74oc9375500c97255ef@mail.gmail.com>
	 <4B432097.2010502@gmail.com>
	 <25aac9fc1001050648l36ec17b1x1dd66ae98f63484d@mail.gmail.com>
	 <25aac9fc1001051228l2c1b92d0n6da618a47634d99a@mail.gmail.com>
	 <4B447390.8040701@gmail.com>
Date: Wed, 6 Jan 2010 12:09:29 +0000
Message-ID: <25aac9fc1001060409o2fddf73cn3d9e7ab790bd352e@mail.gmail.com>
Subject: Re: [DBCP] Continuum Java 5 build - please?
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 06/01/2010, Phil Steitz <phil.steitz@gmail.com> wrote:
> sebb wrote:
>  > On 05/01/2010, sebb <sebbaz@gmail.com> wrote:
>  >> On 05/01/2010, Phil Steitz <phil.steitz@gmail.com> wrote:
>  >>  > sebb wrote:
>  >>  >  > It would be very useful to have a Continuum DBCP build that used Java 5.
>  >>  >  >
>  >>  >  > The current build uses Java 6 only, so does not test JDBC3 compatibility.
>  >>  >  >
>  >>  >  > I don't have Commons Admin on Continuum (and I'm not very familiar
>  >>  >  > with it) so please could an Admin add it?
>  >>  >  >
>  >>  >  > Thanks!
>  >>  >  >
>  >>  >
>  >>  > I will look at this tonight.  It will have to be done using Ant and
>  >>  >  maybe a little scripting, which I am not sure continuum will support.
>  >>
>  >>
>  >> Thanks!
>  >>
>  >>  If it proves difficult to use Continuum with Ant, then I could set up
>  >>  a Hudson build instead.
>  >>
>  >>
>  >>  >  The Ant build in trunk will filter sources in the /build directory
>  >>  >  (not changing src/ itself) when it runs under <= 1.5, but it
>  >>  >  requires build.properties to be set.
>  >>
>  >>
>  >> IMO the Ant build should default to build.properties.sample if
>  >>  build.properties does not exist, but I know others don't agree ... so
>  >>  one possible solution might be to add a target that uses
>  >>  build.properties.sample; or use a variable for the name
>  >>  "build.properties".
>  >>
>  >
>  > The latter already exists:
>  >
>  > ant -Dcomponent-propfile=build.properties.sample ...
>
>
> Still working on this.  Will give it another try this eve.
>
>  I am also completing review of last set of changes to tests and
>  sources. So far, so good.
>
>  Otherwise, are we ready for another RC?
>

There may possibly be a problem with assymetric equals() definitions;
just looking into it now (there are no tests AFAICT).

Also, Javadoc could be improved ... I made a start, but there's rather
a lot to do.
Not essential for this release.

>  Phil
>
> >
>  >>  >  The Maven build under <=1.5 requires that the sources be
>  >>  >  pre-filtered in the src/ directory.
>  >>  >
>  >>  >  I use the Ant build in trunk to test compatibility manually.
>  >>  >
>  >>  >  Phil
>  >>  >  > ---------------------------------------------------------------------
>  >>  >  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >>  >  > For additional commands, e-mail: dev-help@commons.apache.org
>  >>  >  >
>  >>  >
>  >>  >
>  >>  >  ---------------------------------------------------------------------
>  >>  >  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >>  >  For additional commands, e-mail: dev-help@commons.apache.org
>  >>  >
>  >>  >
>  >>
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail: dev-help@commons.apache.org
>  >
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org