Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.220.217 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=PDT/H4qrdv8xeyyCIkeLkGPEepH6DW/+KIQCbXNPgPp50g/njpdlsUahrDvCotMuVv
         xP85Cgp225tVDqyiveH1zlZ3CVVNIWTLka7AJrMm2UnumOBPv2ULYgsvOSgGZl/7FQ1F
         /HHfkmmjSMSmrlWcO5WJlhdlGlqZG3aHVUdt4=
MIME-Version: 1.0
In-Reply-To: <25aac9fc1001041053m749f58aoe1693b6017e68a66@mail.gmail.com>
References: <25aac9fc1001041053m749f58aoe1693b6017e68a66@mail.gmail.com>
Date: Mon, 4 Jan 2010 19:35:22 +0000
Message-ID: <25aac9fc1001041135q33b3ce3ekd8142b07d3af25c3@mail.gmail.com>
Subject: Re: [DBCP] Fixes for next release
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 04/01/2010, sebb <sebbaz@gmail.com> wrote:
> It looks like the multi-threaded tests in TestSharedPoolDataSource
>  have the same problems as the ones in TestPerUserPoolDataSource.
>
>  I'm currently testing to see if I can trigger a failure.

Yes, it fails. Looks to be the same problem - sleep(1) taking much
longer than it should.

>  I also noticed that there are quite a few instances of "data hiding" -
>  i.e. using the same name for a local variable as another variable in
>  scope. I've fixed all such errors in test code - is it OK to do the
>  same for the release code?
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org