Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 36768 invoked from network); 4 Jan 2010 18:53:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Jan 2010 18:53:58 -0000 Received: (qmail 91876 invoked by uid 500); 4 Jan 2010 18:53:57 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 91750 invoked by uid 500); 4 Jan 2010 18:53:57 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 91740 invoked by uid 99); 4 Jan 2010 18:53:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 18:53:57 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates 209.85.220.217 as permitted sender) Received: from [209.85.220.217] (HELO mail-fx0-f217.google.com) (209.85.220.217) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 18:53:49 +0000 Received: by fxm9 with SMTP id 9so13826939fxm.10 for ; Mon, 04 Jan 2010 10:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=U7YjLpI+C1FHJFJmAmbwM0rpQExdZn+QenojChfj+x8=; b=nOgt6l8GdJc7uMIMLCZpEptRiDcnZLmsBIjLjMxprfrkn66hbeWUBDdvSrKuwy0CdJ XONqAnqVJEPuFFskJ3YHdhEXl8rrGidPrH+BJiRM75kVRsze0O/ucY56Fcrj8BcZvsSe +GETlaLS5cZabd6YtiMh3cFT43jnKMF9jdyAc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=b06XksJP3QK2HRfumy8KZu3jUzV5VEb4g4imkDrnkjsxQqM/Z2bkvPYSJ/9TFcehh7 BCapZM3CwFKlr+HESllV29yhI9WJguDbSv67dcXzKWMMWj1j6N1txHzLf6cGk2HohUqZ ZfddgEIDTHbfnez9YhU6ORkIBxu8qpylAlyjI= MIME-Version: 1.0 Received: by 10.239.165.196 with SMTP id y4mr317015hbd.212.1262631209115; Mon, 04 Jan 2010 10:53:29 -0800 (PST) Date: Mon, 4 Jan 2010 18:53:28 +0000 Message-ID: <25aac9fc1001041053m749f58aoe1693b6017e68a66@mail.gmail.com> Subject: [DBCP] Fixes for next release From: sebb To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org It looks like the multi-threaded tests in TestSharedPoolDataSource have the same problems as the ones in TestPerUserPoolDataSource. I'm currently testing to see if I can trigger a failure. I also noticed that there are quite a few instances of "data hiding" - i.e. using the same name for a local variable as another variable in scope. I've fixed all such errors in test code - is it OK to do the same for the release code? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org