commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [DBCP] Fixes for next release
Date Tue, 05 Jan 2010 03:00:35 GMT
sebb wrote:
> On 05/01/2010, Phil Steitz <phil.steitz@gmail.com> wrote:
>> sebb wrote:
>>  > It looks like the multi-threaded tests in TestSharedPoolDataSource
>>  > have the same problems as the ones in TestPerUserPoolDataSource.
>>  >
>>  > I'm currently testing to see if I can trigger a failure.
>>  >
>>  > I also noticed that there are quite a few instances of "data hiding" -
>>  > i.e. using the same name for a local variable as another variable in
>>  > scope. I've fixed all such errors in test code - is it OK to do the
>>  > same for the release code?
>>
>>
>> Yes, but please open JIRAs and update the changelog for these changes.
> 
> OK, DBCP-314 opened, fixed and resolved.
> 
> Hope that's OK.

Looks good.  Thanks!

Phil
> 
>>  Phil
>>  >
>>  > ---------------------------------------------------------------------
>>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  > For additional commands, e-mail: dev-help@commons.apache.org
>>  >
>>
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message