commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simone.trip...@gmail.com>
Subject Re: New sandbox component: at-digester
Date Sat, 09 Jan 2010 13:25:18 GMT
Ok, going to fix it now, thanks!!!

On Sat, Jan 9, 2010 at 1:46 PM, sebb <sebbaz@gmail.com> wrote:
> On 09/01/2010, Simone Tripodi <simone.tripodi@gmail.com> wrote:
>> Guys,
>>  I finally branched the code, I made a mistake during the import (I
>>  copied into trunk/trunk) and I'm very sorry for that, but nothing was
>>  broken.
>
> No problem - sandboxes are for experimentation after all...
>
>>  So now on
>>
>>
>>  https://svn.apache.org/repos/asf/commons/sandbox/at-digester/trunk
>
> Source headers and properties all look OK, however there are a lot of
> @author tags in the new code (whereas the main bulk of Digester does
> not seem to use them)
>
> The board preference is for @author tags to be removed, and AFAIK this
> is the general consensus for Commons projects as well. So I would
> prefer to see these tags removed.
>
> Committer names can be added to the POM.
>
>>
>> here is the current digester/trunk branch.
>>  Thank you for your help, best regards
>>  Simo
>>
>>  On Fri, Jan 8, 2010 at 10:55 AM, Simone Tripodi
>>
>> <simone.tripodi@gmail.com> wrote:
>>  > Hi Henry,
>>  > thanks a lot for your hint!!! Since I already created (and started
>>  > committing code) on the sandbox on
>>  >
>>  > https://svn.apache.org/repos/asf/commons/sandbox/at-digester/trunk
>>  >
>>  > Can I branch the code here? Should I remove the existing stuff on the
>>  > target dir? Many thanks in advance, I'm sorry but I'm not familiar
>>  > with these procedures on commons.
>>  > Best regards!!!!
>>  > SImo
>>  >
>>  > On Fri, Jan 8, 2010 at 8:18 AM, Henri Yandell <flamefew@gmail.com> wrote:
>>  >> You should have the rights.
>>  >>
>>  >> Make the branch into the sandbox rather than inside digester. Something
like:
>>  >>
>>  >> svn mkdir https://svn.apache.org/repos/asf/commons/sandbox/digester-anno/
>>  >> svn cp -m "Branching into the sandbox for annotation changes to
>>  >> digester" https://svn.apache.org/repos/asf/commons/proper/digester/trunk
>>  >> https://svn.apache.org/repos/asf/commons/sandbox/digester-anno/branch-name
>>  >>
>>  >>
>>  >> On Thu, Jan 7, 2010 at 10:57 PM, Simone Tripodi
>>  >> <simone.tripodi@gmail.com> wrote:
>>  >>> Hi all, Jochen, Rahul,
>>  >>> thanks for your help, fine for me working on a branch, I'm more than
>>  >>> pleased to adopt the best solution that fits with the community needs
>>  >>> :)
>>  >>> I don't think I have the rights needed to branch the digester, can
>>  >>> anyone help me please? Many thanks in advance, more than appreciated!
>>  >>> Best regards, have a nice day!
>>  >>> Simo
>>  >>>
>>  >>> On Thu, Jan 7, 2010 at 8:47 PM, Rahul Akolkar <rahul.akolkar@gmail.com>
wrote:
>>  >>>> On Thu, Jan 7, 2010 at 7:11 AM, Simone Tripodi <simone.tripodi@gmail.com>
wrote:
>>  >>>>> Hi Jochen,
>>  >>>>> sorry for the delay (I'm currently at office), I think it
is better if
>>  >>>>> we involve Rahul Akolkar (CC-ed in the mail): I'm an ASF committer
but
>>  >>>>> not a Digester neither Commons committer; in this scenario
I propose
>>  >>>>> to let the community express the opinion in having this new
feature
>>  >>>>> included in a next feature release, if they're interested
I think it
>>  >>>>> could be good investing efforts on it.
>>  >>>> <snip/>
>>  >>>>
>>  >>>> I've been traveling for a couple of weeks (and mostly offline),
but
>>  >>>> otherwise interested in these happenings.
>>  >>>>
>>  >>>> As I mentioned when you posted your proposal initially (not in
a
>>  >>>> position to dig up a link to the archives), I think this feature
has
>>  >>>> good merits in certain usecases and could even be included in
the
>>  >>>> digester trunk when ready. Now that you have access to the Commons
>>  >>>> sandbox, I think its best to work on a digester branch in the
sandbox
>>  >>>> (as suggested already by others) rather than treating it as a
separate
>>  >>>> component. Having said that, whatever works best for you is fine
to
>>  >>>> get the ball rolling here.
>>  >>>>
>>  >>>> Finally, were you a Commons committer already, the sandbox branch
too
>>  >>>> would have been unnecessary (you could have worked on trunk itself).
>>  >>>>
>>  >>>> -Rahul
>>  >>>>
>>  >>>>
>>  >>>>
>>  >>>>> Let me know, have a nice day :)
>>  >>>>> Simo
>>  >>>>>
>>  >>>>> On Thu, Jan 7, 2010 at 9:01 AM, Jochen Wiedmann
>>  >>>>> <jochen.wiedmann@gmail.com> wrote:
>>  >>>>>> On Thu, Jan 7, 2010 at 7:54 AM, Simone Tripodi <simone.tripodi@gmail.com>
wrote:
>>  >>>>>>
>>  >>>>>>> very nice to meet you! I imported the digester as
dependency since,
>>  >>>>>>> fortunately, I don't have to modify the existing code,
but just adding
>>  >>>>>>> a new package that contains the new feature.
>>  >>>>>>
>>  >>>>>> Just adds to my concerns. If you are not even modifying
existing code,
>>  >>>>>> one might even consider not to create a branch.
>>  >>>>>>
>>  >>>>>>
>>  >>>>>> --
>>  >>>>>> Germanys national anthem is the most boring in the world
- how telling!
>>  >>>>>>
>>  >>>>
>>  >>>> ---------------------------------------------------------------------
>>  >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  >>>> For additional commands, e-mail: dev-help@commons.apache.org
>>  >>>>
>>  >>>>
>>  >>>
>>  >>>
>>  >>>
>>  >>> --
>>  >>> http://www.google.com/profiles/simone.tripodi
>>  >>>
>>  >>> ---------------------------------------------------------------------
>>  >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  >>> For additional commands, e-mail: dev-help@commons.apache.org
>>  >>>
>>  >>>
>>  >>
>>  >> ---------------------------------------------------------------------
>>  >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  >> For additional commands, e-mail: dev-help@commons.apache.org
>>  >>
>>  >>
>>  >
>>  >
>>  >
>>  > --
>>  > http://www.google.com/profiles/simone.tripodi
>>  >
>>
>>
>>
>>  --
>>  http://www.google.com/profiles/simone.tripodi
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
http://www.google.com/profiles/simone.tripodi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message