commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release DBCP 1.3/1.4
Date Thu, 24 Dec 2009 15:34:51 GMT
Jörg Schaible wrote:
> Hi Phil,
> 
> Phil Steitz wrote:
> 
>> I have tried to address all of the feedback from the first release
>> candidate and would now like to propose the following artifacts for
>> release as DBCP 1.3 and 1.4.  As previously discussed, the only
>> difference between the two versions is that the 1.3 sources were
>> filtered to exclude JDBC4 methods.
>>
>> Here are the artifacts:
>>
>> 1.3 (JDBC 3) version:
>> http://people.apache.org/~psteitz/dbcp-1.3-rc2
>> http://people.apache.org/~psteitz/dbcp-1.3-rc2/site
>> http://people.apache.org/~psteitz/dbcp-1.3-rc2/maven
>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC2/
> 
> Works and builds now for my compiler zoo == Java 1.5.
> 
> Still fails to build for all Java 1.4 JDK's using Maven 2.0.x due to 
> org.apache.geronimo.specs:geronimo-jta_1.1_spec:1.1.1. Using version 1.1 
> makes the source package at least buildable for Java 1.4 JDKs. However, all 
> Java 1.4 JDKs (Sun, IBM, Blackdown, JRockit) still fail with:
> ============= %< ===============
> -------------------------------------------------------------------------------
> Test set: org.apache.commons.jocl.TestJOCLContentHandler
> -------------------------------------------------------------------------------
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.078 sec 
> <<< FAILURE!
> testObject(org.apache.commons.jocl.TestJOCLContentHandler)  Time elapsed: 
> 0.038 sec
> testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler)  Time 
> elapsed: 0.001 sec
> testParse(org.apache.commons.jocl.TestJOCLContentHandler)  Time elapsed: 
> 0.029 sec  <<< ERROR!
> org.xml.sax.SAXException: System property org.xml.sax.driver not specified
> 	at 
> org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90)
> 	at 
> org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339)
> 	at 
> org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271)
> 	at 
> org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255)
> ============= %< ===============
> 
> Building with Ant still does not produce test reports and succeeds even with  
> AbandonedObjectExceptions with IBM JDK 1.4:
> 
> ============= %< ===============
>     [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: 
> DBCP object created 2009-12-23 12:19:07 by the following code was never 
> closed:                                                                             
  
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138)       
              
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81)
             
>     [junit]     at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) 
              
>     [junit]     at 
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)    
              
>     [junit]     at 
> org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65)
                                                                                         
                      
>     [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)                                        
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)       
              
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:61)       
              
>     [junit]     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60)
             
>     [junit]     at java.lang.reflect.Method.invoke(Method.java:391)                 
                                 
>     [junit]     at junit.framework.TestCase.runTest(TestCase.java:164)              
                                 
>     [junit]     at junit.framework.TestCase.runBare(TestCase.java:130)              
                                 
>     [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)        
                                 
>     [junit]     at 
> junit.framework.TestResult.runProtected(TestResult.java:124)                        
              
>     [junit]     at junit.framework.TestResult.run(TestResult.java:109)              
                                 
>     [junit]     at junit.framework.TestCase.run(TestCase.java:120)                  
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
        
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
     
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567)
       
>     [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: 
> DBCP object created 2009-12-23 12:19:07 by the following code was never 
> closed:                                                                             
  
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138)       
              
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81)
             
>     [junit]     at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) 
              
>     [junit]     at 
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)    
              
>     [junit]     at 
> org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65)
                                                                                         
                      
>     [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)                                        
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)       
              
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:61)       
              
>     [junit]     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60)
             
>     [junit]     at java.lang.reflect.Method.invoke(Method.java:391)                 
                                 
>     [junit]     at junit.framework.TestCase.runTest(TestCase.java:164)              
                                 
>     [junit]     at junit.framework.TestCase.runBare(TestCase.java:130)              
                                 
>     [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)        
                                 
>     [junit]     at 
> junit.framework.TestResult.runProtected(TestResult.java:124)                        
              
>     [junit]     at junit.framework.TestResult.run(TestResult.java:109)              
                                 
>     [junit]     at junit.framework.TestCase.run(TestCase.java:120)                  
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
        
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
     
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567)
       
>     [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: 
> DBCP object created 2009-12-23 12:19:07 by the following code was never 
> closed:                                                                             
  
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138)       
              
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81)
             
>     [junit]     at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) 
              
>     [junit]     at 
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)    
              
>     [junit]     at 
> org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44)
            
>     [junit]     at 
> org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75)
                                                                                         
                 
>     [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)                                        
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)       
              
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:61)       
              
>     [junit]     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60)
             
>     [junit]     at java.lang.reflect.Method.invoke(Method.java:391)                 
                                 
>     [junit]     at junit.framework.TestCase.runTest(TestCase.java:164)              
                                 
>     [junit]     at junit.framework.TestCase.runBare(TestCase.java:130)              
                                 
>     [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)        
                                 
>     [junit]     at 
> junit.framework.TestResult.runProtected(TestResult.java:124)                        
              
>     [junit]     at junit.framework.TestResult.run(TestResult.java:109)              
                                 
>     [junit]     at junit.framework.TestCase.run(TestCase.java:120)                  
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
        
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
     
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567)
       
>     [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: 
> DBCP object created 2009-12-23 12:19:07 by the following code was never 
> closed:                                                                             
  
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138)       
              
>     [junit]     at 
> org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81)
             
>     [junit]     at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) 
              
>     [junit]     at 
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)    
              
>     [junit]     at 
> org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44)
            
>     [junit]     at 
> org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedCloseWithExceptions(TestAbandonedBasicDataSource.java:101)
                                                                                         
  
>     [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)                                        
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)       
              
>     [junit]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:61)       
              
>     [junit]     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60)
             
>     [junit]     at java.lang.reflect.Method.invoke(Method.java:391)                 
                                 
>     [junit]     at junit.framework.TestCase.runTest(TestCase.java:164)              
                                 
>     [junit]     at junit.framework.TestCase.runBare(TestCase.java:130)              
                                 
>     [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)        
                                 
>     [junit]     at 
> junit.framework.TestResult.runProtected(TestResult.java:124)                        
              
>     [junit]     at junit.framework.TestResult.run(TestResult.java:109)              
                                 
>     [junit]     at junit.framework.TestCase.run(TestCase.java:120)                  
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:230)            
                                 
>     [junit]     at junit.framework.TestSuite.run(TestSuite.java:225)                
                                 
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
        
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
     
>     [junit]     at 
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567)
       
> ============= %< ===============
>  
>> 1.4 (JDBC 4) version:
>> http://people.apache.org/~psteitz/dbcp-1.4-rc2
>> http://people.apache.org/~psteitz/dbcp-1.4-rc2/site
>> http://people.apache.org/~psteitz/dbcp-1.4-rc2/maven
>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC2/
> 
> Works and builds now for my compiler zoo >= Java 6.
> 
> Minor nit: It still references the old Java 1.4 XML artifacts and uses a 
> 'wrong' version of xml-apis:
> ============= %< ===============
> [WARNING] While downloading xml-apis:xml-apis:2.0.2
>   This artifact has been relocated to xml-apis:xml-apis:1.0.b2.
> ============= %< ===============
> 
>> Release notes (common version, ships with both)
>> http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>>
>> Vote, please. This VOTE will close 24-December 22:30 GMT.
> 
> Hehehe, I doubt you will have time at that hour exactly ;-)
> 
> commons-dbcp-1.3:
> 
>> [ ] +1 Proceed with release
>> [ ] +0 OK
>> [ ] -0 OK, but I would prefer...
>> [X] -1 No, showstopper = ...
> Should at least buildable with Maven out of the box for JDK 1.4 (you only 
> adjusted the build.properties.sample the last time).
> 
> commons-dbcp-1.4:
> 
>> [X] +1 Proceed with release
>> [ ] +0 OK
>> [ ] -0 OK, but I would prefer...
>> [ ] -1 No, showstopper = ...
> 
> I've modified the trunk and 1.3-branch now. In the 1.3 branch both JOCL 
> tests set the SAX driver explicitly now and the used xerces artifact has 
> been harmonized between Ant and Maven build. Also the proper xml-apis is 
> used now. In trunk I dropped the XML dependencies and the explicit setting 
> in the JOCL test completely, since it runs OOTB with Java 6. I also adjusted 
> the 1.3 pom and build.properties.sample in trunk. However, I wonder if we 
> should drop this anyway, because you cannot build 1.3 from trunk anyway (mvn 
> -f pom-1.3.pom), because of the dropped source filtering for the JDBC 3/4 
> stuff. Changes from trunk can wait for the next release though.
> 
> One last thing: I had one time a NPE that did not result in a failed test 
> (probably because it happened in a different thread):
> ================ %< ===============
> Running org.apache.commons.dbcp.datasources.TestSharedPoolDataSource      
> testMaxWait took 1102 ms                                                  
> Exception in thread "Thread+33" java.lang.NullPointerException            
>         at 
> org.apache.commons.dbcp.datasources.TestSharedPoolDataSource$1.uncaughtException(TestSharedPoolDataSource.java:389)
                                                                                         
                   
> 

Spoke too soon on this one.  I suspect it is an actual bug,
introduced in the fix for DBCP-291, which I have reopened.  Fix in
progress...

Phil

Multithread test time = 645 ms

> Multithread test time = 2326 ms                                                     
                                 
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.089 sec          
                                 
> ================ %< ===============
> 
> - Jörg
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message