commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r890594 - in /commons/proper/dbcp/trunk: pom.xml src/java/org/apache/commons/dbcp/DelegatingConnection.java src/test/org/apache/commons/dbcp/TestJOCLed.java
Date Wed, 16 Dec 2009 01:11:46 GMT
On 15/12/2009, joehni@apache.org <joehni@apache.org> wrote:
> Author: joehni
>  Date: Tue Dec 15 01:12:09 2009
>  New Revision: 890594
>
>  URL: http://svn.apache.org/viewvc?rev=890594&view=rev
>  Log:
>  Use distinguishable hash codes, otherwise IBM JDK 1.6 has a problem with WeakReferences.
>
>  Modified:
>     commons/proper/dbcp/trunk/pom.xml
>     commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java
>     commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestJOCLed.java
>


>  Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java
>  URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java?rev=890594&r1=890593&r2=890594&view=diff
>  ==============================================================================
>  --- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java
(original)
>  +++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java
Tue Dec 15 01:12:09 2009
>  @@ -17,29 +17,27 @@
>
>   package org.apache.commons.dbcp;
>
>  +import java.sql.Array;
>  +import java.sql.Blob;
>   import java.sql.CallableStatement;
>  +import java.sql.ClientInfoStatus;
>  +import java.sql.Clob;
>   import java.sql.Connection;
>   import java.sql.DatabaseMetaData;
>  +import java.sql.NClob;
>   import java.sql.PreparedStatement;
>  +import java.sql.ResultSet;
>  +import java.sql.SQLClientInfoException;
>   import java.sql.SQLException;
>   import java.sql.SQLWarning;
>  +import java.sql.SQLXML;
>   import java.sql.Statement;
>  +import java.sql.Struct;
>  +import java.util.Collections;
>   import java.util.Iterator;
>   import java.util.List;
>   import java.util.Map;
>  -import java.sql.ResultSet;
>  -/* JDBC_4_ANT_KEY_BEGIN */
>  -import java.sql.Array;
>  -import java.sql.Blob;
>  -import java.sql.ClientInfoStatus;
>  -import java.sql.Clob;
>  -import java.sql.NClob;
>  -import java.sql.SQLClientInfoException;
>  -import java.sql.SQLXML;
>  -import java.sql.Struct;
>  -import java.util.Collections;
>   import java.util.Properties;
>  -/* JDBC_4_ANT_KEY_END */
>

Why have the Ant markers been dropped?

SQLClientInfoException (for one) is Java 1.6 only, so surely needs to
be protected by JDBC_4 markers?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message