Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 60672 invoked from network); 22 Nov 2009 19:19:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Nov 2009 19:19:36 -0000 Received: (qmail 61672 invoked by uid 500); 22 Nov 2009 19:19:35 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 61520 invoked by uid 500); 22 Nov 2009 19:19:34 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 61510 invoked by uid 99); 22 Nov 2009 19:19:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Nov 2009 19:19:34 +0000 X-ASF-Spam-Status: No, hits=-3.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.219.192.166] (HELO smtp.bredband2.com) (83.219.192.166) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Nov 2009 19:19:32 +0000 Received: from [192.168.0.3] (c-83-233-111-92.cust.bredband2.com [83.233.111.92]) by smtp.bredband2.com (Postfix) with ESMTPA id 42819B8D64 for ; Sun, 22 Nov 2009 20:18:57 +0100 (CET) Message-ID: <4B098EA5.1020005@apache.org> Date: Sun, 22 Nov 2009 20:19:01 +0100 From: Dennis Lundberg User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Commons Developers List Subject: Re: [dbcp] 1.3 release problems References: <4B096A2A.4040702@gmail.com> In-Reply-To: <4B096A2A.4040702@gmail.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Bredband2-MailScanner: Found to be clean X-Bredband2-MailScanner-From: dennisl@apache.org X-Old-Spam-Status: No Phil Steitz wrote: > I am running into some problems preparing for dbcp-1.3. I would > appreciate comments / patches on any of the issues below. > > 1. Findbugs is showing some real (inconsistent synch) and not so > real (e.g. serialization issues on classes that IMO should not be > serializable, but we can't fix until 2.0). The full report is here: > http://commons.apache.org/dbcp/findbugs.html > I would appreciate suggestions/patches/commits for what to fix and how. > > 2. We can't compile commons-pool-1.3.jar against JDK 1.6 (JDBC 4) > and expect it to work for JDK 1.4/1.5 (JDBC 3) clients (at least not > as the code stands today). So we need to create two jar artifacts. > The question is which one gets the 1.3 name, what is the other > named and how do we package the distros? I see two possible naming schemes for this, both of them using classifiers in the same way that Maven does. 1. commons-pool-1.3-jdk14.jar and commons-pool-1.3-jdk16.jar 2. commons-pool-1.3-jdbc3.jar and commons-pool-1.3-jdbc4.jar Both of these schemes have a classifier on *both* artifacts. If you want to eliminate one of the classifiers I'd propose to skip the classifier on the JDBC 3 artifact, since that is what is currently out there in the 1.2.x versions of commons-dbcp. Then it would be 3. commons-pool-1.3.jar and commons-pool-1.3-jdk16.jar 4. commons-pool-1.3.jar and commons-pool-1.3-jdbc4.jar > > 3. I assume it is OK at this point to drop the nojdbc3 Ant target > and compiler flags for JDBC 2. > > TIA > > Phil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > -- Dennis Lundberg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org