commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [DBCP] Noisy test output
Date Wed, 25 Nov 2009 16:26:24 GMT
sebb wrote:
> On 23/11/2009, sebb <sebbaz@gmail.com> wrote:
>> The JUnit tests produce a lot of output, even if the tests are successful.
>>
>>  Is there really any need to print stack traces in the following method?
>>
>>  TestSharedPoolDataSource.PoolTest.run()
>>
>>  I propose to comment them out.
>>
>>  Similarly, the test case TestManual.testLogWriter() generates a lot of output.
>>  It's not clear to me what the test is trying to achieve.
>>  Any ideas?
>>
> 
> Does anyone know what TestAbandonedBasicDataSource.testAbandoned() is
> trying to test? It seems to be similar to testAbandonedClose() except
> that it does not close the connections.

Looks like it is testing to make sure the "abandoned" connections
get closed (the abandoned timeout is 0, maxActive is 1 and multiple
connections are opened in sequence).
> 
> As far as I can tell it achieves nothing at present, except to print
> some  useless messages on System.err. I propose to remove the
> printouts (and inline the resulting one-line private methods)

Fixed.

Phil
> 
> OK?
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message