commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [dbcp] Callable statement pooling (DBCP-204)
Date Tue, 10 Nov 2009 03:25:23 GMT
Mark Thomas wrote:
> Phil Steitz wrote:
>> OK, I am now feeling stupid.
> You and me both.
> 
>> GKOP already has LRU-cache like
>> behavior. (See clearOldest test in allocate()).  Given compat
>> issues, I am inclined to move forward with 0).
> 
> +1
> 
> We'll also need pool 1.5.4 as well to fix an edge case where the pool
> could lock up.
> 
> Mark
> 

One question.  The patch introduces a statement type flag as part of
the key to distinguish prepared statements from callable statements.
   I am not sure this is necessary.  Can anyone imagine a scenario
where the same exact sql is used in prepareStatement and
prepareCall?  Are there drivers that even allow this ("call" in
prepareStatement sql, or no "call" in prepareCall) If not, we do not
need the additional flag.

Phil
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message