commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: Comments on Commons Lang 3.0-SNAPSHOT
Date Tue, 17 Nov 2009 07:54:40 GMT
On Mon, Nov 16, 2009 at 11:48 PM, Henri Yandell <flamefew@gmail.com> wrote:
> On Mon, Nov 16, 2009 at 10:16 AM, Paul Benedict <pbenedict@apache.org> wrote:
>
> Effectively, I think code on top of java.math is a fine fit for Lang,
> whereas Commons Math is a wholly different bigger beastie.
>
>> * System is missing IS_JAVA_1_7 constant
>
> Fair enough.

*cheers at the issue assigned to you*

>> * I think the division of EscapeUtils and UnescapeUtils is
>> unnecessary. Do others think it's complex enough to make them separate
>> classes? I imagine so, but just checking.
>
> It felt like a lot for one class, but we're the package with a near
> 6000 line StringUtils class, so 130 line classes are piddly. One thing
> I noticed is that I need to javadoc the Escape/UnescapeUtils classes.
> I'm happy to merge them if an EscapeUtils is preferred. Or even to
> kill EscapeUtils/UnescapeUtils and make StringEscapeUtils undeprecated
> and the intended front door.

I'll do that. Delete EscapeUtils and UnescapeUtils; replace
StringEscapeUtils with their merged contents.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message