From dev-return-116414-apmail-commons-dev-archive=commons.apache.org@commons.apache.org Fri Oct 09 06:45:48 2009 Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 60860 invoked from network); 9 Oct 2009 06:45:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Oct 2009 06:45:48 -0000 Received: (qmail 27836 invoked by uid 500); 9 Oct 2009 06:45:48 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 27705 invoked by uid 500); 9 Oct 2009 06:45:47 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 27695 invoked by uid 99); 9 Oct 2009 06:45:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2009 06:45:47 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jak-commons-dev@m.gmane.org designates 80.91.229.12 as permitted sender) Received: from [80.91.229.12] (HELO lo.gmane.org) (80.91.229.12) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2009 06:45:36 +0000 Received: from list by lo.gmane.org with local (Exim 4.50) id 1Mw9E3-0002lA-Vh for dev@commons.apache.org; Fri, 09 Oct 2009 08:45:15 +0200 Received: from mail.elsag-solutions.com ([62.154.225.82]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Oct 2009 08:45:15 +0200 Received: from joerg.schaible by mail.elsag-solutions.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Oct 2009 08:45:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: dev@commons.apache.org From: =?UTF-8?B?SsO2cmc=?= Schaible Subject: Re: [VOTE] Release BeanUtils 1.8.1 based on RC1 Date: Fri, 09 Oct 2009 08:44:51 +0200 Lines: 107 Message-ID: References: <55afdc850910080731v20ac9a93i77413ccf473d7197@mail.gmail.com> <55afdc850910081503y7aef6abn80fb93e723b7cffe@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: mail.elsag-solutions.com User-Agent: KNode/0.10.9 Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Niall Pemberton wrote at Freitag, 9. Oktober 2009 00:03: > Hi Jörg, > > Thanks for testing, comments inline... > [snip] >> >> Issues with Sun JDK 1.3.1: >> ========================== >> >> Source compilable, but a lot of tests fail. > > All the tests pass for me - I was using Ant 1.7.1 and Sun's JDK > 1.3.1_18 on Windows XP - but I tried Ant 1.6.5 and JDK 1.3.1_20 (again > on WinXP) and also had no problems. Are the tests actually failing or > are you just seeing alot of exceptions in the output? Because > BeanUtils uses reflection to intialise the "cause" when re-throwing > exceptions for JDK 1.4+, but for JDK 1.3 it logs the stack trace of > the original exception. For example: > > http://commons.apache.org/beanutils/xref/org/apache/commons/beanutils/PropertyUtilsBean.html#2194 > http://commons.apache.org/beanutils/xref/org/apache/commons/beanutils/BeanUtilsBean.html#1041 I'll have a closer look this evening when I'm back from office, but, yes, it looks like a lot of those. >> Issues with IBM JDK 1.4.2 and 1.5: >> ================================== >> >> 1/ strange warnings on console for one test: > > The class thats being tested logs those warnings for null values: > > http://commons.apache.org/beanutils/xref/org/apache/commons/beanutils/BeanPropertyValueChangeClosure.html#170 [snip] I simply wondered, why these warnings appear for those two JDKs only. However, it might also related to the fact that I've build those with Maven 1 and the mechanism to catch the console output is different (or configured in a different way). >> >> 2/ org.apache.commons.beanutils.bugs.Jira347TestCase: 1 Error > > This test was copied from MemoryLeakTestCase and the same problem > occurred for BeanUtils 1.8.0 when you tested with maven1 and IBM JDKs. > Would be nice to get these tests working (wonder if they work with IBM > JDK and ant, rather than maven1) but I can't seem to find anywhere to > download the IBM JDK for windows. So since its a problem in the test > rather than actual BeanUtils functionality I can only suggest that we > ignore this again, unless someone can come up with a fix for the test: > > http://commons.markmail.org/message/6fhsjmrugz6c746y see my reply to sebb [snip] >> Issues with IBM JDK 1.6: >> ======================== >> >> 1/ org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase >> ================ %< ==================== > > OK so the IBM JDK 1.6 got past the setup problems and fails the actual > test. This is disappointing because it means the fix we put in for the > memory leak that works on Sun's JDK doesn't seem to work for IBM JDK > 1.6. I've created a bug report for this: > > https://issues.apache.org/jira/browse/BEANUTILS-366 > > ...but its going to need someone to fix this or for me to get the IBM > JDK. Anyway those same tests fail in Sun's JDK 1.3 & JDK 1.4 - so > theres a check so they don't run on pre-1.5 JDKs - can't find anything > in the archives as to why they fail or the results of any > investigation. Anyway I don't believe this is something new in this > release and the attitude we took with the memory leak fixes is that if > they work in some JDKs (i.e Suns) then thats progress even if they > don't resolve it for all JDKs. Anyway I've logged the bug but I'm > hoping this won't stop this release since none of the changes made > since 1.8.0 go anywhere near the caching that causes/caused the memory > leaks. We might add something to release notes about known issues then. [snip] >> Minor nits: >> ========== >> xdocs/changes.xml: BEANUTILS-354 is reported twice > > Thanks I fixed this in trunk: Hehe, you additionally spotted the year of the release. I'm currently filling my tax forms for last year, so it did look quite too familiar for me :)) - Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org