From dev-return-116597-apmail-commons-dev-archive=commons.apache.org@commons.apache.org Sat Oct 24 17:35:39 2009 Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 13361 invoked from network); 24 Oct 2009 17:35:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Oct 2009 17:35:39 -0000 Received: (qmail 94511 invoked by uid 500); 24 Oct 2009 17:35:38 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 94400 invoked by uid 500); 24 Oct 2009 17:35:38 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 94390 invoked by uid 99); 24 Oct 2009 17:35:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Oct 2009 17:35:38 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (nike.apache.org: transitioning domain of ralph.goers@dslextreme.com does not designate 209.85.210.189 as permitted sender) Received: from [209.85.210.189] (HELO mail-yx0-f189.google.com) (209.85.210.189) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Oct 2009 17:35:28 +0000 Received: by yxe27 with SMTP id 27so9393847yxe.10 for ; Sat, 24 Oct 2009 10:35:07 -0700 (PDT) Received: by 10.101.46.15 with SMTP id y15mr7768472anj.4.1256405707233; Sat, 24 Oct 2009 10:35:07 -0700 (PDT) Received: from ?192.168.10.132? (cpe-75-82-178-177.socal.res.rr.com [75.82.178.177]) by mx.google.com with ESMTPS id 7sm607479yxd.26.2009.10.24.10.35.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 24 Oct 2009 10:35:06 -0700 (PDT) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v1076) Subject: Re: [CONFIGURATION] Which CombinedConfiguration From: Ralph Goers In-Reply-To: <4AE31D07.2030908@oliver-heger.de> Date: Sat, 24 Oct 2009 10:35:04 -0700 Content-Transfer-Encoding: 7bit Message-Id: <34D69762-EED2-4C02-9FDE-4E3889395BD5@dslextreme.com> References: <2bacf5dd0910071431o628d5309q69fd8d61143e64a6@mail.gmail.com> <4ACD7E9A.6010308@oliver-heger.de> <5AA6853D-EFDD-47D6-A99D-ACF6A5DEC6FD@dslextreme.com> <4AD0A6EF.4070501@oliver-heger.de> <4AD385B0.3020106@oliver-heger.de> <4AE31D07.2030908@oliver-heger.de> To: "Commons Developers List" X-Mailer: Apple Mail (2.1076) X-Virus-Checked: Checked by ClamAV on apache.org On Oct 24, 2009, at 8:28 AM, Oliver Heger wrote: > I have now completed a major update of DefaultConfigurationBuilder > to use the new combined.CombinedConfiguration class instead of the > old one. > > DefaultConfigurationBuilder was the main cause for the existence of > duplicated classes because if it switches to the new > CombinedConfiguration, all types of sub configurations it supports > must be hierarchical. This has been achieved by means of the > AbstractFlatConfiguration base class, which simulates a hierarchical > configuration on top of a flat one. > > Currently I get 3 test failures. 2 are in > TestPreferencesConfiguration and may be unrelated to my changes (a > problem with access rights on a windows registry key - I just > switched to Windows 7; need to check on a different machine). The > other one is in TestMultiFileHierarchicalConfiguration, the test for > schema validation. It should not be too difficult to get this test > running again, but I am not sure about the desired outcome: The > reload causes an exception, which cleared the content of the sub > configuration. However, the combined configuration is currently not > notified about this change and keeps its (stale) data. I did not fix reloading in configuration2. Now that you have done the major work I should be able to get that done. If I can't get it done sooner I definitely plan on doing it during ApacheCon. > > I am not sure whether all changes performed at CombinedConfiguration > and DynamicCombinedConfiguration have been applied to the new > classes in the combined package. Please have a look. If these > classes are merged, we can actually start to remove the old ones. Thanks. I will do a comparison and make the necessary changes. > > A final remark: I don't know what is required to make the > configuration2 branch usable. The approach with > AbstractFlatConfiguration is an attempt to make all configuration > classes hierarchical. The approach with configuration sources (i.e. > the stuff in the base package) has the same purpose, and it seems to > be more elegant and powerful. So I would like to follow this path a > bit more. Again, during ApacheCon I hope to spend some time reviewing the classes. I would like to end up with HierarchicalConfiguration being an interface that is primarily used by applications, especially if the configuration is injected by Spring. Also, I was speaking with a colleague about how multi-valued items are supported and he made some suggestions that I am going to look into further. I'll post my thoughts as I really look into that. Ralph --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org