commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Armstrong <davidarmstrong...@gmail.com>
Subject Re: [PATCH]Commons IO New Functionality, Minor Patches
Date Fri, 30 Oct 2009 01:56:59 GMT
Hi Zukka,

I created a feature request. Its key is IO-222 and here is a link to it:
https://issues.apache.org/jira/browse/IO-222

I attached a diff file after "svn adding" my new source files like you
said and a gzipped tar file of the project with the proposed new
functionality. I reverted back to the latest svn version of
IOUtils.java with the multiple closeQuietly() methods, in the interest
of backwards compatibility.

I look forward to hearing what you guys think about it.

Best Regards,
David Armstrong

On Thu, Oct 29, 2009 at 9:46 AM, James Carman
<james@carmanconsulting.com> wrote:
> I have a couple of methods that you might want to include in a FileUtils class:
>
> public static void touch(File file);
> public static void deleteDirectory(File dir);
>
>
> On Thu, Oct 29, 2009 at 10:29 AM, Jukka Zitting <jukka.zitting@gmail.com> wrote:
>> Hi,
>>
>> On Wed, Oct 28, 2009 at 4:42 AM, David Armstrong
>> <davidarmstrong000@gmail.com> wrote:
>>> The new functionality is a class that copies files, called FileCopier
>>> and some helper classes. This class goes beyond the functionality of
>>> the static methods included in the FileUtils class. It has the
>>> following functionality:
>>
>> Sounds like an useful addition. Can you file a feature request about
>> this in https://issues.apache.org/jira/browse/IO and attach the code
>> there? It would be easier for us to review the code if you could
>> provide it as a patch against the latest svn trunk. That way it would
>> be clearer what parts you have changed and how. You can get a nicely
>> formatted patch with "svn diff" after you've "svn add"ed all the new
>> files you've created.
>>
>>> The patches I included are pretty minor. For FileUtils.java, I changed
>>> the access for doCopyFile() from private to protected so that
>>> FileCopier could make use of its functionality. For IOUtils.java, I
>>> replaced the multiple closeQuietly() methods with one closeQuietly()
>>> method that takes an object that implements Closeable as its argument.
>>> If these patches are not acceptable, please let me know.
>>
>> The latter change sounds like something that could break binary
>> backwards compatibility.
>>
>> BR,
>>
>> Jukka Zitting
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message