commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: svn commit: r825420 - in /commons/proper/lang/trunk/src: java/org/apache/commons/lang/ClassUtils.java test/org/apache/commons/lang/ClassUtilsTest.java
Date Thu, 15 Oct 2009 20:03:34 GMT
On Thu, Oct 15, 2009 at 1:34 AM, Jörg Schaible <joerg.schaible@gmx.de> wrote:
>
> --------------- Weitergeleitete Nachricht (Anfang)
>
> Betreff: svn commit: r825420 - in /commons/proper/lang/trunk/src:
> java/org/apache/commons/lang/ClassUtils.java
> test/org/apache/commons/lang/ClassUtilsTest.java
> Absender: bayard-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
> Datum: Thu, 15 Oct 2009 09:31:33 +0200
> Newsgruppe: gmane.comp.jakarta.commons.scm
>
> Author: bayard
> Date: Thu Oct 15 07:31:32 2009
> New Revision: 825420
>
> URL: http://svn.apache.org/viewvc?rev=825420&view=rev
> Log:
> Applying my patch from LANG-535 - adding support to getShortClassName and
> getPackageName for arrays, including primitive arrays and multi-dimensional
> arrays. Also stopped getPackageName relying on the underlying
> class.getPackage as it's sometimes null
>
> Modified:
>    commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java
>
> commons/proper/lang/trunk/src/test/org/apache/commons/lang/ClassUtilsTest.java
>
> Modified:
> commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java?rev=825420&r1=825419&r2=825420&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java
> (original)
> +++ commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java
> Thu Oct 15 07:31:32 2009
> @@ -188,6 +188,24 @@
>             return StringUtils.EMPTY;
>         }
>
> +        StringBuffer arrayPrefix = new StringBuffer();
>
>
> We should start to use StringBuilder in such situations now ... ;-)

Agreed, I started that way then decided that instead a
StringBuffer->StringBuilder cross Lang change should be considered. I
suspect there aren't that many places that rely on the
synchronization, maybe the Builders.

Mental note for me to create a JIRA ticket tonight.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message