Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 31293 invoked from network); 12 Sep 2009 20:02:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Sep 2009 20:02:46 -0000 Received: (qmail 81695 invoked by uid 500); 12 Sep 2009 20:02:46 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 81550 invoked by uid 500); 12 Sep 2009 20:02:45 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 81540 invoked by uid 99); 12 Sep 2009 20:02:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Sep 2009 20:02:45 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of charlesmchen@gmail.com designates 209.85.219.213 as permitted sender) Received: from [209.85.219.213] (HELO mail-ew0-f213.google.com) (209.85.219.213) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Sep 2009 20:02:36 +0000 Received: by ewy9 with SMTP id 9so1187509ewy.25 for ; Sat, 12 Sep 2009 13:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=OxnFdZD7h4fswb5oYSM3ePbhVYPtRUaG7GASiVJhn0s=; b=PNRg1gpKNDwbeyleW0Hfs8GHHvs+RdBciwyYKuGy6ucjhwWjucgD4AyErpm78BqwJ+ H9CzutrQzYIEKRbTxwCHSoXPOMkaF9C2fiuwXxONDAyAF16ep+FUJ//LzbeEhC3kpepf RbVTT4BJKsmSnjEyKjnHzgxUwdNAZxwawo/Cg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=mMPMn5zDpDRoMVdvplGy3T3egjdvhCFrGgRJD4DYkgTZZfMX4Prkerv5HVZ1fL2cnZ z0aS3zvGDsGkErN2It+oLXrtkBlTkrB4/ojmcvJXyjLcg1SHHaQr3haQjO8IqyIM5tZw l2b5lKEtJd6ew2q+acKfbI/Qxg/TChANB60O0= MIME-Version: 1.0 Received: by 10.216.89.129 with SMTP id c1mr1081103wef.35.1252785735725; Sat, 12 Sep 2009 13:02:15 -0700 (PDT) In-Reply-To: <31cc37360909121224i2b0922cct760b66054706e506@mail.gmail.com> References: <31cc37360909121224i2b0922cct760b66054706e506@mail.gmail.com> Date: Sat, 12 Sep 2009 16:02:15 -0400 Message-ID: Subject: Re: [sanselan] Commit messages and JIRA ids [was: Resolved: (SANSELAN-26) Move ...] From: Charles Matthew Chen To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Thanks for the advice - I'll be sure to follow it. Matthew On Sat, Sep 12, 2009 at 3:24 PM, Henri Yandell wrote: > The former is also crucial for anyone trying to work things out from > your svn logs. Usually the commit message is quite low on information > and having a link to the bugzilla entry or JIRA entry is great. > > The latter is less crucial but useful because a) svn commit tab in > JIRA has been known to break and b) it makes it nice and easy to write > the closing message in JIRA :) I just copy and paste my SVN > input/output straight into the JIRA and both message, files involved > and revision are now recorded. > > Hen > > On Sat, Sep 12, 2009 at 11:38 AM, Rahul Akolkar = wrote: >> Moved from issues@ ... >> >> Two requests: >> =A0* Please add the issue identifier (such as SANSELAN-26 here) in the >> SVN commit message(s) so commits appear in the "Subversion commits" >> tab in the corresponding JIRA issue >> =A0* For added measure, best to indicate the SVN revision for the fix in >> the JIRA comment when resolving issue. >> >> TIA. >> -Rahul >> >> >> On Sat, Sep 12, 2009 at 1:42 PM, Charles Matthew Chen (JIRA) >> wrote: >>> >>> =A0 =A0 [ https://issues.apache.org/jira/browse/SANSELAN-26?page=3Dcom.= atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] >>> >>> Charles Matthew Chen resolved SANSELAN-26. >>> ------------------------------------------ >>> >>> =A0 =A0Resolution: Fixed >>> >>> =A0* Fixed a couple of platform-dependent paths in the tests. >>> =A0* Constant-ized the magic numbers used when guessing formats. >>> =A0* Added a test for the format guessing. >>> >>> >>>> Move Image magic numbers to constants >>>> ------------------------------------- >>>> >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Key: SANSELAN-26 >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 URL: https://issues.apache.org/jira/br= owse/SANSELAN-26 >>>> =A0 =A0 =A0 =A0 =A0 =A0 Project: Commons Sanselan >>>> =A0 =A0 =A0 =A0 =A0Issue Type: Improvement >>>> =A0 =A0Affects Versions: 0.94-incubator >>>> =A0 =A0 =A0 =A0 Environment: All >>>> =A0 =A0 =A0 =A0 =A0 =A0Reporter: Ashish Paliwal >>>> =A0 =A0 =A0 =A0 =A0 =A0Priority: Minor >>>> =A0 Original Estimate: 1h >>>> =A0Remaining Estimate: 1h >>>> >>>> All the Image magic numbers used in Sanselan.guessFormat() API can be = moved to constants. As of now they are hardcoded within the API >>> >>> -- >>> This message is automatically generated by JIRA. >>> - >>> You can reply to this email to add a comment to the issue online. >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org