Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of lists@nabble.com designates
 216.139.236.158 as permitted sender)
Message-ID: <25259429.post@talk.nabble.com>
Date: Wed, 2 Sep 2009 08:08:30 -0700 (PDT)
From: Henrib <hbiestro@gmail.com>
To: dev@commons.apache.org
Subject: Re: svn commit: r810445 - in /commons/proper/jexl/branches/2.0/src:
  main/java/org/apache/commons/jexl/
 main/java/org/apache/commons/jexl/parser/
  test/java/org/apache/commons/jexl/
In-Reply-To: <25aac9fc0909020331g391d546ek9e55953a717e94dd@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
References: <20090902102303.EBA3723888E9@eris.apache.org>
 <25aac9fc0909020331g391d546ek9e55953a717e94dd@mail.gmail.com>


sebb-2-2 wrote:
> 
> 
> Seems like a complicated way of fixing the problem; I would have
> thought it was simpler to ensure that multiple statements are
> separated by ";" instead.
> 
> i.e. a script consists of
> 
> Statement ( ";" Statement )*
> 
> So long as "Statement" includes a null statement, this would allow for
> a trailing ";".
> 
> But I don't know JavaCC all that well.
> 

Did you try fixing the grammar using what you suggest ? If you actually have
implemented it in a simpler way - versus thought about one - please, share
the code so we can all learn; I've tried many solutions and did not come up
with the current code easily.
Besides, the fix forces 2 expressions to be separated by ';' in a statement
- which is not equivalent to separate all statements with ';' (';'  needed
between blocks?).


-- 
View this message in context: http://www.nabble.com/svn-commit%3A-r810445---in--commons-proper-jexl-branches-2.0-src%3A-main-java-org-apache-commons-jexl--main-java-org-apache-commons-jexl-parser--test-java-org-apache-commons-jexl--tp25255016p25259429.html
Sent from the Commons - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org