commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r817291 - /commons/sandbox/runtime/trunk/src/main/java/org/apache/commons/runtime/util/Utils.java
Date Tue, 22 Sep 2009 16:05:10 GMT

On Sep 22, 2009, at 11:51 AM, Jim Jagielski wrote:

>
> On Sep 22, 2009, at 10:56 AM, Mladen Turk wrote:
>
>> On 22/09/09 16:06, Jim Jagielski wrote:
>>>
>>> On Sep 21, 2009, at 11:51 AM, Jim Jagielski wrote:
>>>
>>>>
>>>> On Sep 21, 2009, at 11:34 AM, mturk@apache.org wrote:
>>>>>
>>>>> + private static final String [] try_envs = {
>>>>> + "TMP",
>>>>> + "TEMP",
>>>>> + "TMPDIR",
>>>>> + "TEMPDIR"
>>>>> + };
>>>>
>>>> Not sure about that ordering, unless we want to favor Windows.
>>>> For Unix the canonical envvar is TMPDIR, so it should likely be
>>>> checked 1st (and this the 1st element), and then go down the  
>>>> others...
>>>>
>>>> Of course, we could even get more sophisticated and have 2; one for
>>>> Windows and another for non-Windows, so the ordering makes more  
>>>> sense
>>>> depending on the platform ;)
>>>>
>>>> OK if I fold something like that in?
>>>>
>>>
>>> Didn't hear back, so I'll be conservative and not do so...
>>>
>>
>> It's just like with APR. See unix/tempdir.c
>> The order is: TMP, TEMP, TMPDIR (and I added TEMPDIR)
>
> which itself was based on Python 2.2 (earlier used TMPFILE) :)

FWIW, later versions of Python use "my" ordering:

     # First, try the environment.
     for envname in 'TMPDIR', 'TEMP', 'TMP':
         dirname = _os.getenv(envname)
         if dirname: dirlist.append(dirname)



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message