commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r810445 - in /commons/proper/jexl/branches/2.0/src: main/java/org/apache/commons/jexl/ main/java/org/apache/commons/jexl/parser/ test/java/org/apache/commons/jexl/
Date Wed, 02 Sep 2009 16:11:55 GMT
On 02/09/2009, Henrib <hbiestro@gmail.com> wrote:
>
>
>
>  sebb-2-2 wrote:
>  >
>  >
>  > Seems like a complicated way of fixing the problem; I would have
>  > thought it was simpler to ensure that multiple statements are
>  > separated by ";" instead.
>  >
>  > i.e. a script consists of
>  >
>  > Statement ( ";" Statement )*
>  >
>  > So long as "Statement" includes a null statement, this would allow for
>  > a trailing ";".
>  >
>  > But I don't know JavaCC all that well.
>  >
>
>
> Did you try fixing the grammar using what you suggest ? If you actually have
>  implemented it in a simpler way - versus thought about one - please, share
>  the code so we can all learn; I've tried many solutions and did not come up
>  with the current code easily.

No, I've not tried fixing it. I may try later.

>  Besides, the fix forces 2 expressions to be separated by ';' in a statement
>  - which is not equivalent to separate all statements with ';' (';'  needed
>  between blocks?).

Not sure I follow what you mean by this - can you provide an example
of a script which used to be parsed incorrectly?

>
>
>  --
>  View this message in context: http://www.nabble.com/svn-commit%3A-r810445---in--commons-proper-jexl-branches-2.0-src%3A-main-java-org-apache-commons-jexl--main-java-org-apache-commons-jexl-parser--test-java-org-apache-commons-jexl--tp25255016p25259429.html
>  Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message