Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 98804 invoked from network); 11 Aug 2009 18:01:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Aug 2009 18:01:47 -0000 Received: (qmail 44754 invoked by uid 500); 11 Aug 2009 17:50:20 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 44692 invoked by uid 500); 11 Aug 2009 17:50:20 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 44682 invoked by uid 99); 11 Aug 2009 17:50:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2009 17:50:19 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rahul.akolkar@gmail.com designates 74.125.92.150 as permitted sender) Received: from [74.125.92.150] (HELO qw-out-1920.google.com) (74.125.92.150) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2009 17:50:11 +0000 Received: by qw-out-1920.google.com with SMTP id 14so1392731qwa.60 for ; Tue, 11 Aug 2009 10:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=/pURcM1ld8HbzAXsNzGwluTV5x5d8sUDgi039WAw8rk=; b=cJsqGopQMLwcqlRAgBxuIDcXsNP/S+zcB/u9EtcmxlTG6agrVVpRmcyH6y1aYK0hsP IVWBZmQoWwxSJJohER5heSID/7eDv1j/VjuFl4GcajQLHDGrpLtNB/N+7zJqh0ffbwAA Z8pkkjX5ci10pC8Uaru1o1HYzrE5UwS29TJ7M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=sTeJoaA100lAkanuH7mzYSr1tFts0kZiqpEj5IaWlva2z1rSDDJ8khnFXhMvvkk4cj hr4dbHu0fmrSmke+DUbgJFBTmucg+EXdAJnR+21WcA3DfCrAPdD5XJZ3edptbxZvhr3S rhm1ZLddM50S2TjXIA/tNOvC0FSi0LqrJ16zA= MIME-Version: 1.0 Received: by 10.224.13.66 with SMTP id b2mr177169qaa.370.1250012990998; Tue, 11 Aug 2009 10:49:50 -0700 (PDT) Date: Tue, 11 Aug 2009 13:49:50 -0400 Message-ID: Subject: Re: [JEXL] svn commit: r803067 From: Rahul Akolkar To: dev@commons.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Aug 11, 2009 at 7:40 AM, wrote: > Author: sebb > Date: Tue Aug 11 11:40:08 2009 > New Revision: 803067 > > URL: http://svn.apache.org/viewvc?rev=3D803067&view=3Drev > Log: > Boxing/unboxing > > Modified: > =A0 =A0commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/= jexl/ArrayLiteralTest.java > =A0 =A0commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/= jexl/examples/ArrayTest.java > =A0 =A0commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/= jexl/examples/MethodPropertyTest.java > Don't need to do this for test classes (whats been done is fine) -- tests are easier to read with the autoboxing IMO. -Rahul > Modified: commons/proper/jexl/branches/2.0/src/test/java/org/apache/commo= ns/jexl/ArrayLiteralTest.java > URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/te= st/java/org/apache/commons/jexl/ArrayLiteralTest.java?rev=3D803067&r1=3D803= 066&r2=3D803067&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/ArrayLiteralTest.java (original) > +++ commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/ArrayLiteralTest.java Tue Aug 11 11:40:08 2009 > @@ -47,7 +47,7 @@ > =A0 =A0 =A0 =A0 JexlContext jc =3D JexlHelper.createContext(); > > =A0 =A0 =A0 =A0 Object o =3D e.evaluate( jc ); > - =A0 =A0 =A0 =A0Object[] check =3D { 5, 10 }; > + =A0 =A0 =A0 =A0Object[] check =3D { Integer.valueOf(5), Integer.valueOf= (10) }; > =A0 =A0 =A0 =A0 assertTrue( Arrays.equals(check, (Object[])o) ); > =A0 =A0 } > > > Modified: commons/proper/jexl/branches/2.0/src/test/java/org/apache/commo= ns/jexl/examples/ArrayTest.java > URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/te= st/java/org/apache/commons/jexl/examples/ArrayTest.java?rev=3D803067&r1=3D8= 03066&r2=3D803067&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/examples/ArrayTest.java (original) > +++ commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/examples/ArrayTest.java Tue Aug 11 11:40:08 2009 > @@ -57,7 +57,7 @@ > =A0 =A0 =A0 =A0 e =3D jexl.createExpression("array[0].length()"); > =A0 =A0 =A0 =A0 o =3D e.evaluate(jc); > > - =A0 =A0 =A0 =A0out.print("The length of the string at location 0 is : "= , o, 21); > + =A0 =A0 =A0 =A0out.print("The length of the string at location 0 is : "= , o, Integer.valueOf(21)); > =A0 =A0 } > > =A0 =A0 /** > > Modified: commons/proper/jexl/branches/2.0/src/test/java/org/apache/commo= ns/jexl/examples/MethodPropertyTest.java > URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/te= st/java/org/apache/commons/jexl/examples/MethodPropertyTest.java?rev=3D8030= 67&r1=3D803066&r2=3D803067&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/examples/MethodPropertyTest.java (original) > +++ commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jex= l/examples/MethodPropertyTest.java Tue Aug 11 11:40:08 2009 > @@ -71,7 +71,7 @@ > > =A0 =A0 =A0 =A0 e =3D jexl.createExpression("foo.convert(1+number)"); > =A0 =A0 =A0 =A0 o =3D e.evaluate(jc); > - =A0 =A0 =A0 =A0out.print("value of " + e.getExpression() + " is : ", o,= foo.convert(1+number)); > + =A0 =A0 =A0 =A0out.print("value of " + e.getExpression() + " is : ", o,= foo.convert(1+number.intValue())); > > =A0 =A0 =A0 =A0 /* > =A0 =A0 =A0 =A0 =A0* access a property > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org