Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of rahul.akolkar@gmail.com
 designates 74.125.92.147 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=t5Jgk2pBSrXR89A3WDnRLWf2Bs0nq5be8rJc0IGWIpOogpgkXACWKiLYgt1qWFKvy2
         0TmlTuUuW5iwUnCKVbUzL7DuboMbMlPiX4tGK4ADExexI3MoWyJYJsDEDhi+51aW3LRG
         +k1g5d83P7fpwK+Vl1zjvwjW5s72UBfLjYksE=
MIME-Version: 1.0
In-Reply-To: <25aac9fc0908040842j6586ad24k6dbf0de14bc1e9e7@mail.gmail.com>
References: <25aac9fc0908030857t210e7303nef47d31425d8ab60@mail.gmail.com>
	 <ce1f2ea80908031351s3e9b2103h1528b4af96f180bd@mail.gmail.com>
	 <25aac9fc0908031848k6cd7c6aeif921009510b99a6b@mail.gmail.com>
	 <25aac9fc0908040842j6586ad24k6dbf0de14bc1e9e7@mail.gmail.com>
Date: Tue, 4 Aug 2009 13:01:03 -0400
Message-ID: <ce1f2ea80908041001o6ddd6e51n3b08d23d0ae5c1c3@mail.gmail.com>
Subject: Re: [JEXL] Handling of deprecated items in 2.0
From: Rahul Akolkar <rahul.akolkar@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 4, 2009 at 11:42 AM, sebb<sebbaz@gmail.com> wrote:
> On 04/08/2009, sebb <sebbaz@gmail.com> wrote:
>> On 03/08/2009, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>> =A0> On Mon, Aug 3, 2009 at 11:57 AM, sebb<sebbaz@gmail.com> wrote:
>> =A0> =A0> There are some classes and methods which are now deprecated in=
 2.0.
>> =A0> =A0>
>> =A0> =A0> However, the deprecated items are still used by much of the te=
st code.
>> =A0> =A0>
>> =A0> =A0> Seems to me that the test cases ought not to use deprecated cl=
asses
>> =A0> =A0> and methods unless the test is actually for testing the item.
>> =A0> =A0>
>> =A0> =A0> Any views on this?
>> =A0> =A0>
>> =A0>
>> =A0> <snip/>
>> =A0>
>> =A0> =A0Sure makes sense to remove usage in tests. One step further, giv=
en
>> =A0> =A0that a major release is one of the few occassions we can actuall=
y do
>> =A0> =A0this, we can look at removing some deprecated methods and classe=
s
>> =A0> =A0altogether if it helps clean things up and gets us a cleaner,
>> =A0> =A0unambiguous API as a result.
>>
>>
>> +1
>
> There are now no references to the deprecated classes and methods in
> any of the code.
>
> I removed the deprecated stuff from the workspace, and "mvn clean
> test" works OK.
>
> So I think we could consider dropping the two classes:
>
> ExpressionFactory
> ScriptFactory
>
<snip/>

Yes, I'm OK with this since it helps the API -- with a prominent note
in RELEASE-NOTES.txt (which we should prepare towards to 2.0 anyway).


> and removing the methods:
>
> JexlEngine.getDefault()
<snap/>

JexlEngine is @since 2.0 so once the two classes above disappear, this
serves no useful purpose and can be promptly removed.


> and
> Info.getTemplateName()
>
<snip/>

Yup, this can go as well.

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org