commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [codec] Are we ready for Codec 1.4 RC4?
Date Thu, 06 Aug 2009 13:42:37 GMT
On 06/08/2009, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> Are there any more changes people want to do before cutting another
>  Codec 1.4 RC?

I just did a quick scan looking for any mutable variables.
There are some variables which ought to be final; these are already
documented as to be treated as final so no problem.

The only exception is DoubleMetaphone.maxCodeLen, which needs
revisiting for a later release.

There is one package protected static final array, i.e.
Base64.CHUNK_SEPARATOR (test code needs access)

This could be fixed by adding a package protected accessor which
returned a copy of the array and making the array private. That's not
essential.

Otherwise looks OK to me.

>  Niall
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message