commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Charles Matthew Chen <charlesmc...@gmail.com>
Subject Re: [jira] Created: (SANSELAN-25) Support for reading Radiance HDR images
Date Fri, 10 Jul 2009 02:54:18 GMT
Hi Peter,

   This is great, nice work.  Here are some notes:

   1.  Please modify the getAllImageParsers() method of ImageParser to
include your new parser - please place it last in the list of parsers
since it is a less common format.

http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/ImageParser.java?view=co

   2.  If the Radiance HDR has "magic numbers" at the beginning of the
file which can be used to guess the format, please update the
guessFormat() method of Sanselan to reflect this.  This will enable
Sanselan to detect and handle misnamed image files as well as
inputstreams (such as network streams) without an associated filename.

http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/sanselan/Sanselan.java?view=co

   3.  Please override the getAcceptedExtensions() method of
ImageParser in HdrImageParser to reflect the file extensions
associated with this format.  Check out one of the other ImageParsers
for an example.

   4.  Please add tests if possible for these classes.  Sanselan's
unit test coverage is fairly poor at the moment - most of the tests
are integration tests.  Improving the unit test coverage is an
important goal that we're working on, and it'd be nice to add tests as
we add or update code.

http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/test/java/org/apache/sanselan/formats/?

   5.  Please contribute sample images in the Radiance HDR format if
you can.  Improving the suite of test images has a number of important
benefits.  For one thing, the integration tests will automatically
incorporate them.

http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/test/data/images/?

Cheers,
   Matthew


On Thu, Jul 9, 2009 at 9:28 AM, peter royal (JIRA)<jira@apache.org> wrote:
> Support for reading Radiance HDR images
> ---------------------------------------
>
>                 Key: SANSELAN-25
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-25
>             Project: Commons Sanselan
>          Issue Type: New Feature
>            Reporter: peter royal
>
>
> I have added support for reading Radiance HDR images to Sanselan. The code is available
at http://github.com/osi/sanselan/tree/radiance-hdr
>
> If the changes look good (i was specifically curious about http://github.com/osi/sanselan/commit/f29c13db8479aca7b421876fcc001d180d384458#L0R92
relative to the overall library design), I can commit them as I have commons commit privs.
>
> Just wanted to raise this as an issue prior to just slamming changes in :)
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message