commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [JEXL] towards 2.0 release, code freeze ?
Date Tue, 28 Jul 2009 19:21:40 GMT
On 28/07/2009, Henrib <hbiestro@gmail.com> wrote:
>
>
>
>  sebb-2-2 wrote:
>  >
>  >
>  > Now that the code requires Java 1.5, there are a lot of complaints
>  > from the Eclipse compiler about Type Safety and Raw Types. I think
>  > these should ideally be fixed.
>  >
>  > Findbugs complains:
>  >
>  > There is an apparent infinite recursive loop in Interpreter:
>  >
>  >     public void setAttribute(Object object, Object attribute, Object
>  > value) {
>  >         setAttribute(object, attribute, null);
>  >     }
>  >
>  > Also complains: forgets to throw the Exception for:
>  >         if (node == null) {
>  >             new UnsupportedOperationException("unable to set object
>  > property, "
>  >                             + "object:" + object + ", property: " +
>  > attribute);
>  >         }
>  >
>  >
>
>
> Thans you for committing modifications for those; unfortunately, JEXL-60 is
>  *so* big that it's not a patch file (it was a spitting a lot of rejects). I
>  guess I will have to re-post the tar.gz attachment with your modifications
>  in; could you ping this thread when you're done ?
>  Thanks
>

Ah, sorry, I did not realise there were some pending patches.

I've finished for the time being - there are still a few raw types,
but I don't know what they are all supposed to be.

>
>  --
>  View this message in context: http://www.nabble.com/-JEXL--towards-2.0-release%2C-code-freeze---tp24699493p24705372.html
>
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>
>  ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message