commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: [MATH] MATH-278 - Robust locally weighted regression (Loess / Lowess)
Date Sat, 20 Jun 2009 14:48:41 GMT
sebb a écrit :
> On 20/06/2009, sebb <sebbaz@gmail.com> wrote:
>> https://issues.apache.org/jira/browse/MATH-278 - Robust locally
>>  weighted regression (Loess / Lowess) is a patch to provide a new
>>  class:
>>
>>  org.apache.commons.math.analysis.interpolation.LoessInterpolator
>>
>>  together with Test case.
>>
>>  I've made some comments in the JIRA regarding the Java coding, which
>>  the OP has addressed.
>>
>>  However, I've no idea whether the new class is in the appropriate
>>  package, or whether it is even appropriate for Math - as far as I can
>>  tell it seems OK, but I'm only familiar with the Java aspects of Math,
>>  not the algorithms.
>>
>>  I can apply the patch, but it would be good if someone more familiar
>>  with the codebase could double-check.
>>
> 
> Crossed in the post - I see that Luc has just dealt with the patch.

Yes. I found it was good and the package was appropriate since there was
already spline and polynomial (Neville) interpolators. It could also
have been put in the stat.regression perhaps.
The only changes I made to the patch were whitespace and error messages.

Luc

> 
>>  S///
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message