commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r787118 - /commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java
Date Mon, 22 Jun 2009 09:09:31 GMT
On 22/06/2009, billbarker@apache.org <billbarker@apache.org> wrote:
> Author: billbarker
>  Date: Mon Jun 22 00:26:09 2009
>  New Revision: 787118
>
>  URL: http://svn.apache.org/viewvc?rev=787118&view=rev
>  Log:
>  Yes, sebb is correct.  After running tests, readResolve needs to be visible to subclasses
to be used.  Since Complex is clearly designed to be subclassed, changing the visiblity.

[I don't claim responsibility - Bloch wrote the book!]

Are these tests easy to add to the test suite?

>  Modified:
>     commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java
>
>  Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java
>  URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java?rev=787118&r1=787117&r2=787118&view=diff
>  ==============================================================================
>  --- commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java
(original)
>  +++ commons/proper/math/trunk/src/java/org/apache/commons/math/complex/Complex.java
Mon Jun 22 00:26:09 2009
>  @@ -976,7 +976,7 @@
>       * @return A Complex instance with all fields resolved.
>       * @since 2.0
>       */
>  -    private final Object readResolve() {
>  +    protected final Object readResolve() {
>          return createComplex(real, imaginary);
>      }
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message