commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release commons-email-1.2 based on RC1
Date Fri, 12 Jun 2009 17:33:16 GMT
On 12/06/2009, Siegfried Goeschl <siegfried.goeschl@it20one.at> wrote:
> Hi Sebastian,
>
>  I remembered on my way home that I had the same issue when running the
>  test without network connectivity a few weeks ago ....

I just tried with the network disconnected, and the 3 failures
disappeared. However, a different one appeared:

EmailLiveTest.testHtmlMailMimeLayout() - invalid URL, which is
generated by HtmlEmail.embed(URL url, String name) when it tries to
check that the URL is readable.
In this case, the URL is http://www.apache.org/images/asf_logo_wide.gif.

As I wrote before, I think the tests ought to work without needing
internet access.
I don't know how easy that will be...

>  Sorry for the wasted cycles

Not sure what you mean. Seems to be a normal vote thread so far.

==

May I suggest you use a tag with an RCn suffix in future, as was done for POOL?

==

I've fixed the POM to add the encoding properties (and fix a typo)

>
>  Siegfried Goeschl
>
>  sebb wrote:
>  > On 12/06/2009, sebb <sebbaz@gmail.com> wrote:
>  >
>  >> On 12/06/2009, sebb <sebbaz@gmail.com> wrote:
>  >>  > On 12/06/2009, Siegfried Goeschl <siegfried.goeschl@it20one.at>
wrote:
>  >>  >  > Hi Sebastian,
>  >>  >  >
>  >>  >  >  see my comments inlined ...
>  >>  >  >
>  >>  >  >  For the rest of us :
>  >>  >  >
>  >>  >  >  +) the missing AL headers in pom.xml are an M2 issue I had before
>  >>  >  >  +) the broken tests needs investigation since they work on my
box and Gump
>  >>  >  >
>  >>  >  >  Cheers,
>  >>  >  >
>  >>  >  >  Siegfried Goeschl
>  >>  >  >
>  >>  >  >
>  >>  >  >  sebb wrote:
>  >>  >  >  > On 11/06/2009, Siegfried Goeschl <siegfried.goeschl@it20one.at>
wrote:
>  >>  >  >  >
>  >>  >  >  >> Hi folks,
>  >>  >  >  >>
>  >>  >  >  >>  I would like to call a vote for releasing commons-email-1.2
..... :-)
>  >>  >  >  >>
>  >>  >  >  >>  Tag:
>  >>  >  >  >>
>  >>  >  >  >>  https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_2
>  >>  >  >  >>
>  >>  >  >  >
>  >>  >  >  > I tested against:
>  >>  >  >  >
>  >>  >  >  > Last Changed Rev: 783930
>  >>  >  >  >
>  >>  >  >  > AL headers are missing from
>  >>  >  >  > commons-email.iml
>  >>  >  >  > commons-email.ipr
>  >>  >  >  > pom.xml
>  >>  >  >  >
>  >>  >  >  > I wonder whether the first two files belong in SVN at all.
>  >>  >  >  >
>  >>  >  >
>  >>  >  >
>  >>  >  > No - those two files actually belong to svn:ignore but I encountered
SVN
>  >>  >  >  problems and did not notice that the got into the release
>  >>  >
>  >>  >
>  >>  > They are not it the archives, but they are in SVN.
>  >>  >
>  >>  >
>  >>  >  > > Given that Maven downloads the required libraries, I cannot
see the
>  >>  >  >  > need to include the following files in the lib directory:
>  >>  >  >  >
>  >>  >  >  > subethasmtp-smtp-1.2-java14.jar
>  >>  >  >  > subethasmtp-wiser-1.2-java14.jar
>  >>  >  >  >
>  >>  >  >  > I think the entire directory should be removed from SVN (it's
not in
>  >>  >  >  > the source archives).
>  >>  >  >  >
>  >>  >  >
>  >>  >  > That stuff is not available at the public M2 repo and ancient (summer
2007)
>  >>  >
>  >>  >
>  >>  > mvn test (mostly) worked for me using the source archive which does
>  >>  >  not have the files so I think the files can be deleted from SVN.
>  >>  >
>  >>  >
>  >>  >  > > A few missing SVN properties:
>  >>  >  >  >
>  >>  >  >  > svn ps svn:eol-style native RELEASE-NOTES.txt
>  >>  >  >  > svn ps svn:eol-style native lib/README.txt
>  >>  >  >  > svn ps svn:mime-type application/pdf src/test/attachments/logo.pdf
>  >>  >  >  > svn ps svn:eol-style native xdocs/release_1_1.xml
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >
>  >>  >  > Thanks
>  >>  >  >
>  >>  >  > >>  Site:
>  >>  >  >  >>
>  >>  >  >  >>  http://people.apache.org/builds/commons/email/1.2/RC1/site/index.html
>  >>  >  >  >>
>  >>  >  >  >
>  >>  >  >  > The site does not mention which version of Java is needed;
it could
>  >>  >  >  > perhaps be mentioned in the "Releases" section on the front
page.
>  >>  >  >  >
>  >>  >
>  >>  >
>  >>  > What about the above?
>  >>  >
>  >>  >
>  >>  >  >  >
>  >>  >  >  >>  Binaries:
>  >>  >  >  >>
>  >>  >  >  >>  http://people.apache.org/builds/commons/email/1.2/RC1/staged/commons-email/commons-email/1.2/
>  >>  >  >  >>
>  >>  >  >  >
>  >>  >  >  > The build.xml file is useless, as it refers to maven-build.xml
which is missing.
>  >>  >  >  > As the code requires 1.4+, there's no need for an Ant build
- delete
>  >>  >  >  > the file build.xml
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >
>  >>  >  > Will do that
>  >>  >  >
>  >>  >  > > Maven 2 reports:
>  >>  >  >  >
>  >>  >  >  > [WARNING] Using platform encoding (Cp1252 actually) to copy
filtered
>  >>  >  >  > resources, i.e. build is platform dependent!
>  >>  >  >  >
>  >>  >  >  > The POM needs to be fixed.
>  >>  >
>  >>  >
>  >>  > And this? There are some missing properties.
>  >>  >
>  >>  >
>  >>  >  >  >
>  >>  >  >  > Three test cases fail:
>  >>  >  >  >
>  >>  >  >  > testEmbedUrl(org.apache.commons.mail.HtmlEmailTest)  Time
elapsed: 2.5
>  >>  >  >  > sec  <<< FAILURE!
>  >>  >  >  > junit.framework.AssertionFailedError: Should have thrown
an exception
>  >>  >  >  >       at junit.framework.Assert.fail(Assert.java:47)
>  >>  >  >  >       at org.apache.commons.mail.HtmlEmailTest.testEmbedUrl(HtmlEmailTest.java:190)
>  >>  >  >  >
>  >>  >  >  > testAttach(org.apache.commons.mail.MultiPartEmailTest)  Time
elapsed:
>  >>  >  >  > 1.703 sec  <<< FAILURE!
>  >>  >  >  > junit.framework.AssertionFailedError: Should have thrown
an exception
>  >>  >  >  >       at junit.framework.Assert.fail(Assert.java:47)
>  >>  >  >  >       at org.apache.commons.mail.MultiPartEmailTest.testAttach(MultiPartEmailTest.java:237)
>  >>  >  >  >
>  >>  >  >  > testAttach3(org.apache.commons.mail.MultiPartEmailTest) 
Time elapsed:
>  >>  >  >  > 1.625 sec  <<< FAILURE!
>  >>  >  >  > junit.framework.AssertionFailedError: Should have thrown
an exception
>  >>  >  >  >       at junit.framework.Assert.fail(Assert.java:47)
>  >>  >  >  >       at org.apache.commons.mail.MultiPartEmailTest.testAttach3(MultiPartEmailTest.java:313)
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >
>  >>  >  > Needs to be investigated - the tests pass obviously on my box
>  >>  >  >
>  >>  >  > >>  [ ] +1 release it
>  >>  >  >  >>  [ ] +0 go ahead I don't care
>  >>  >  >  >>  [X] -1 no, do not release it because
>  >>  >  >  >>
>  >>  >  >  >
>  >>  >  >  > Missing AL Headers in pom.xml and .pom also test failures
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >
>  >>  >  > Missing AL Headers in pom.xml - I still have the M2 issues that
it
>  >>  >  >  removes the AL from pom.xml during the release process. I played
around
>  >>  >  >  with yesterday it but Maven kept doing that
>  >>  >
>  >>  >
>  >>  > IIRC it depends on the exact layout of the start of the POM.
>  >>  >  Compare the mail pom with a recent build that worked, e.g. compress
or pool.
>  >>  >
>  >>
>  >>
>  >> By the way, Findbugs reports the following:
>  >>
>  >>
>  >>  commons-email/src/java/org/apache/commons/mail/HtmlEmail.java:269
>  >>
>  >>  org.apache.commons.mail.HtmlEmail.embed(URL, String) invokes
>  >>  java.net.URL.equals(Object), which blocks to do domain name resolution
>  >>
>  >>
>  >>  The code should be changed if possible to use a different way of
>  >>  comparing the URLs.
>  >>
>  >>
>  >>  The class BaseEmailTestCase has no tests, and should probably be made abstract.
>  >>
>  >>  The same 3 tests fail for me using Eclipse on the SVN trunk code.
>  >>  I'll see if I can work out what the problem is.
>  >>
>  >>
>  >
>  > I've just realised that the problem is caused because I'm using
>  > OpenDNS, so all URLs resolve.
>  >
>  > I think the tests need to be changed anyway, as they should not rely
>  > on there being no TLD called "url"; AFAIK only the TLD "invalid" is
>  > guaranteed to be invalid (but unfortunately not in OpenDNS). Does it
>  > make sense to have a unit test that requires an internet connection?
>  >
>  >
>  >>  >  > >>  Thanks in advance
>  >>  >  >  >>
>  >>  >  >  >>  Siegfried Goeschl
>  >>  >  >  >>
>  >>  >  >  >>  PS: Special thanks to Corey Scott for providing a lot
of patches
>  >>  >  >  >>
>  >>  >  >  >>  ---------------------------------------------------------------------
>  >>  >  >  >>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >>  >  >  >>  For additional commands, e-mail: dev-help@commons.apache.org
>  >>  >  >  >>
>  >>  >  >  >>
>  >>  >  >  >>
>  >>  >  >  >
>  >>  >  >  > ---------------------------------------------------------------------
>  >>  >  >  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >>  >  >  > For additional commands, e-mail: dev-help@commons.apache.org
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >  >
>  >>  >  >
>  >>  >  >  ---------------------------------------------------------------------
>  >>  >  >  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >>  >  >  For additional commands, e-mail: dev-help@commons.apache.org
>  >>  >  >
>  >>  >  >
>  >>  >
>  >>
>  >>
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail: dev-help@commons.apache.org
>  >
>  >
>  >
>  >
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message