Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of phil.steitz@gmail.com
 designates 209.85.218.161 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=A2rWcfX6nBgMpGR82sia+lSYF9ilic6irUMLpv9/ydh8poMXBuouE2EawX9LPWPhDQ
         E/JEav3yWpkhPBq8dh1Skz6dpHVqE3evo7uJEuNIEZZipcP40EzyKKChjSKM/8BiqJoK
         k5tkJ3/hgd2txhFl2AxBy2XgVx+HmvUcw+RQs=
MIME-Version: 1.0
In-Reply-To: 
 <358001741.5492921241615031336.JavaMail.root@spooler6-g27.priv.proxad.net>
References: <4A016405.4060202@gmail.com>
	 <358001741.5492921241615031336.JavaMail.root@spooler6-g27.priv.proxad.net>
Date: Wed, 6 May 2009 11:48:10 -0400
Message-ID: <8a81b4af0905060848t5c0758c0lb97588f19c75f4d6@mail.gmail.com>
Subject: Re: svn commit: r772114 - in /commons/proper/math/trunk/src:
	java/org/apache/commons/math/stat/regression/
 test/org/apache/commons/math/stat/regression/
From: Phil Steitz <phil.steitz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thanks, Luc. I am fine with the change. You're right that in this (and
lots if other cases), we should be either looking at relative error or
setting tolerances by element.

On 5/6/09, luc.maisonobe@free.fr <luc.maisonobe@free.fr> wrote:
> The first element in the reference table has a large magnitude (3.48e6). =
The
> error tolerance was 1.0e-8 which was 14 digits smaller. The change from
> RealMatrix to RealVector scheduled the numeric operations differently,
> despite the same values should theoretically be computed (the matrix used
> was a 1x1 matrix from which the trace was extracted, now we compute a
> vectorial dot product which leads to a double).
> After the change, the resulting value was about -3482258.63459583 (last
> significant digit changed). This seemed acceptable to me. A better change
> would probably have been to replace an absolute threshold by a relative
> threshold.
>
> Do you want me to revert the change ?
>
> Luc
>
> ----- "Phil Steitz" <phil.steitz@gmail.com> a =E9crit :
>
>> >
>> >      /**
>> >
>> > Modified:
>> commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regressi=
on/OLSMultipleLinearRegressionTest.java
>> > URL:
>> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apac=
he/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java?rev=3D=
772114&r1=3D772113&r2=3D772114&view=3Ddiff
>> >
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> > ---
>> commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regressi=
on/OLSMultipleLinearRegressionTest.java
>> (original)
>> > +++
>> commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regressi=
on/OLSMultipleLinearRegressionTest.java
>> Wed May  6 09:40:13 2009
>> > @@ -139,7 +139,7 @@
>> >            new double[]{-3482258.63459582, 15.0618722713733,
>> >                  -0.358191792925910E-01,-2.02022980381683,
>> >                  -1.03322686717359,-0.511041056535807E-01,
>> > -                 1829.15146461355}, 1E-8); //
>> > +                 1829.15146461355}, 2E-8); //
>> >
>> What caused this?
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org