commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [VOTE] Release commons-compress-1.0 based on RC1
Date Tue, 12 May 2009 05:04:29 GMT
>>  Tag:
>>  https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/
>
> I don't like the use of final tag names for release candidates; tags
> should be immutable, so how can one generate another release candidate
> if this one fails?
> I'm not sure what the solution to this is as I don't know enough Maven.

I think similar, but this has been done automatically when following:
http://wiki.apache.org/commons/CreatingReleases


>>  Site:
>>  http://people.apache.org/builds/commons/compress/1.0/RC1/site/index.html
>
> Could not find any reference to the required JVM version.

I added 1.4.2 as required java version.

> Also the front page still refers partly to sandbox status:
>
> # The code is unreleased
> # Methods and classes can and will appear and disappear without warning
> # If you like the code and want to push it towards a release, join the
> mailing list!
>

Its deleted.

>
>>  Binaries:
>>  http://people.apache.org/builds/commons/compress/1.0/RC1/staged/org/apache/commons/commons-compress/1.0/
>
> Hashes of sigs (.asc.md5 and .asc.sha1) are created by Maven, but
> should be deleted as they serve no purpose.

OK I deleted them, just for the sake of completnes.

> The OSGI information in commons-compress-1.0.jar looks wrong - surely
> the compress packages should only be listed in the Export section, and
> not the Import section as well?
>
> Presumably this is a pom.xml config error rather than a plugin error,
> but I have no idea how to fix it.
>
> I think the Import section should be empty, as compress has no
> dependencies (apart from junit for testing). I don't know if that
> means it should be omitted, or just left empty.

no idea... this is defined in parent pom.

but is it really an error?
The new dbutils has it in it too:

Import-Package: javax.sql,org.apache.commons.dbutils;version="1.2",org
 .apache.commons.dbutils.handlers;version="1.2",org.apache.commons.dbu
 tils.wrappers;version="1.2"

> CpioArchiveInputStreamTest.java does not have an AL header.

fixed

> Some of the test files don't have AL headers either, but that's probably OK.

i think so


> testCpioUnarchive(org.apache.commons.compress.archivers.CpioTestCase)
> junit.framework.AssertionFailedError: length of
> C:\DOCUME~1\User\LOCALS~1\Temp\dir20685\test1.xml expected:<80> but
> was:<76>
>
> Perhaps this is an EOL issue?

it runs on my box (OS X 10.4) - which system are you using?

> I think there's no point releasing with the OSGI error.

if it is one :-)

Cheers Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message