commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [pool] 1.5-RC1 available for review
Date Fri, 29 May 2009 12:11:47 GMT
On 29/05/2009, Phil Steitz <phil.steitz@gmail.com> wrote:
> The files are here:
>  http://people.apache.org/~psteitz/commons-pool-1.5-RC1/

findbugs filter and license-header.txt are missing from source archives.

RELEASE-NOTES.txt is missing from the SVN tag.

NOTICE.txt has 2008.

I'm not sure why, but the $Id: SVN tags in some of the XML files
differ between the source file and a checkout of the SVN tag. This
should not happen if the tag is used to create the build.

It would be nice if the sources jar manifest had Spec. and Impl. entries.

Ant test works OK on Java 1.3.1

Mvn test (Java 1.6.0) reports

[WARNING] Using platform encoding (Cp1252 actually) to copy filtered
resources, i.e. build is platform dependent!

Also the test fails for me:

Failed tests:
testBorrowObjectFairness(org.apache.commons.pool.impl.TestGenericObjectPool)
 Time elapsed: 2.468 sec  <<< FAILURE!
junit.framework.AssertionFailedError
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.fail(Assert.java:53)
	at org.apache.commons.pool.impl.TestGenericObjectPool.testBorrowObjectFairness(TestGenericObjectPool.java:1434)

The Test case ought to be a bit more explicit as to why the test failed.

I suspect it may be an error in the unit-test code - the TestThread
class has various fields that are accessed across threads without any
synchronisation.

>  The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_RC1/

NOTICE.txt says:

Copyright 1999-2008 The Apache Software Foundation

I think this does need to be fixed.

DOAP file does not have an AL header (not a blocker, I'll fix trunk)

>  Have at it!
>
>  Thanks!
>
>  Phil
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message