commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [COLLECTIONS] 3.3 RC1 for review
Date Thu, 21 May 2009 15:24:41 GMT
On 21/05/2009, Henri Yandell <flamefew@gmail.com> wrote:
> I don't expect this to pass the first vote - they never do :)
>
>  ---
>
>  Tag:
>
>  https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_3_3_RC1

Which revision is this? I'm assuming r777000 (nice number!)

Two files don't have AL headers:

doap_collections.rdf
pom.xml

This means the .pom file is also missing the AL header.

NOTICE.txt says:
Copyright 2001-2008

README.txt includes full details of the Ant targets, but does not
mention any Maven targets. It should mention the ones that correspond
to the Ant details.

The directory:

src/test/org/apache/commons/collections/functors

is empty and could perhaps be deleted?

>  Site:
>
>  http://people.apache.org/builds/commons/collections/3.3/RC1/site/index.html

It would be useful to mention the Java version requirement more
prominently, e.g. on the front page and/or in the dependencies report.

The ApacheCon logo is out of date.

>  Binaries:
>
>  http://people.apache.org/builds/commons/collections/3.3/RC1/staged/commons-collections/commons-collections/3.3/

It would be useful to record the Md5 hashes, because the same file
names will be used for RC2 etc:

commons-collections-3.3-bin.tar.gz.md5
9fff73c7eb945b89beb8a63c47dd3191

commons-collections-3.3-bin.zip.md5
63db5cbf9fa54e0876fa8249b27ee3a7

commons-collections-3.3-javadoc.jar.md5
4c4f4fda141295cb8267ae251f09c5f1

commons-collections-3.3-sources.jar.md5
125c0db7c344749a5b05bf3b953267cf

commons-collections-3.3-src.tar.gz.md5
308212cfa1d180df373e0fad1a517325

commons-collections-3.3-src.zip.md5
fef79aae60d779bea7e65fe63a49cea3

commons-collections-3.3.jar.md5
c142e4e4c9e4310b6570250ae6b76aff

commons-collections-3.3.pom.md5
40e4cb46b2d6332ba52ca300716e3bdc

It would also be useful to include the file name in the MD5 and SHA1 files, e.g.

40e4cb46b2d6332ba52ca300716e3bdc *commons-collections-3.3.pom

The tgz and zip archives agree with each other, and the source archive
agrees with SVN apart from CRLF/LF differences and times in SVN $Date:
markers, which are unfortunately expressed in local time.

Source builds and tests OK using:
* Ant 1.7.1/Java 1.3.1
Total time: 4 minutes 14 seconds

* Maven 2.10/Java 1.4.2
Tests run: 13023, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.422 sec

I've no idea why the Ant tests take so much longer.
Part of it is probably that they run as separate tests, but surely
that cannot account for all the extra time?

Are there some tests missed out by Maven?

The jars all have N&L files.

It would be nice if the javadoc and source jar manifests included the
Specification and Implementation headers. See commons-compress pom.xml
for how to add these.

-1 based on the missing AL headers and wrong Copyright year.

>
>  Clirr: http://people.apache.org/~bayard/commons-collections/diff.txt-clirr.txt
>
>  Jardiff: http://people.apache.org/~bayard/commons-collections/diff.txt-jardiff.html
>
>  ---
>
>  Currently I've noticed that the site/release notes say 'JDK 1.2' when
>  in fact it's 1.3 source/target from a 1.5 JDK. Also the test jar is
>  not deployed to the Maven repository. That can be done manually if
>  desired.
>
>  I'm interested in what others find.
>
>  Hen
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message