Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 23182 invoked from network); 23 Apr 2009 12:13:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Apr 2009 12:13:38 -0000 Received: (qmail 54896 invoked by uid 500); 23 Apr 2009 12:13:37 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 54773 invoked by uid 500); 23 Apr 2009 12:13:37 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 54763 invoked by uid 99); 23 Apr 2009 12:13:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2009 12:13:37 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of grobmeier@gmail.com designates 209.85.218.161 as permitted sender) Received: from [209.85.218.161] (HELO mail-bw0-f161.google.com) (209.85.218.161) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2009 12:13:30 +0000 Received: by bwz5 with SMTP id 5so512438bwz.42 for ; Thu, 23 Apr 2009 05:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=mkGbSWZgJFLTYfMAp2bpGf+GDZYnCh7MKLz02yhBJGk=; b=geMmUdVkD8KFtyvE/ovHPA2teJ1Roz0w1kELQOX1zJ3h6jXgJwAvfjhlIoT4NqFGvF P/odXN7GzfvGu2D0ktIPjt4kYTer5PFWInnS7u2pVwU3T0NOHSi/t7p/EszO32iONQo4 KeKv6weGHZ63ChWvBCfaUZ0hKCBjPm1crQRoo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=rxtF1nTdHZHQTz/f+3ZKmnRNtHMuU/OeVBYNOeTmXBUU9u0Ce+xEEuvkO/IbZMGpHU wDDQAOcTGOCT1X8pmzF24KX1rP5ojw50dnBAPpL2g3/LUAru6UZxDqR5/UHFVa7CT+fE 2sB0APSjs6fIojiVl8heYAw7YnJvh1tWVmz2M= MIME-Version: 1.0 Received: by 10.223.109.19 with SMTP id h19mr290503fap.20.1240488789097; Thu, 23 Apr 2009 05:13:09 -0700 (PDT) In-Reply-To: <25aac9fc0904230504w7c8baf5ex508e8f644e35faab@mail.gmail.com> References: <25aac9fc0904230440m6d2faf68k425ed4cf9e26d26c@mail.gmail.com> <6c59d89a0904230449w33fe6543h1aedeeab09571043@mail.gmail.com> <25aac9fc0904230504w7c8baf5ex508e8f644e35faab@mail.gmail.com> From: Christian Grobmeier Date: Thu, 23 Apr 2009 14:12:54 +0200 Message-ID: Subject: Re: [COMPRESS] COMPRESS-64 - enforcing correct sequence of API calls To: Commons Developers List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org > Well, it may involve a bit more work now - which I don't mind doing - > but adding a new archiver should be easier, as it would not have to do > the state checking. > > The idea is to have the re-usable code in the abstract super-class. I completly understand your point. But does this bring so much benefit? We check for two fields, I am not sure if this brings so much benefit. Additionally, if we do this, I would prefer to have: doFinish instead of finish0 in the subclasses :-) That 0 looks so... technical :-) cheers, Christian --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org